favicon.js fails with cross origin href due to lacking required attribute (security)

[avoidwork]

Description

The favicon loaded on https://guided.adobe.com used to work, but now it errors with a canvas DOM security error due to the favicon.js lacking the crossOrigin attribute to allow access.

Test plan / Steps to Reproduce

1. Visit https://guided.adobe.com, an uncaught error will happen & the application will halt suggesting using Brave & other browsers (this is a regression between March '18 & now).

Actual result:
resolve(canvas.toDataURL('image/png')) fails with a DOM error

VM447:1 Uncaught DOMException: Failed to execute 'toDataURL' on 'HTMLCanvasElement': Tainted canvases may not be exported.
    at eval (eval at img.onload (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/content/scripts/favicon.js:13:7), <anonymous>:1:8)
    at Image.img.onload (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/content/scripts/favicon.js:13:7)
(anonymous) @ VM447:1
img.onload @ favicon.js:13
load (async)
Promise @ favicon.js:7
getBase64FromImageUrl @ favicon.js:2
(anonymous) @ favicon.js:25

Expected result:
resolve(canvas.toDataURL('image/png')) succeeds

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.23.31
V8: 6.7.288.46
rev: 3148ace
Muon: 7.1.5
OS Release: 10.0.17134
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.103

Reproducible on current live release:
Yes

Additional Information

This error did not exist when I made guided.adobe.com public in March'18.

[avoidwork]

Hi,

This apparently also affects some government sites in canada, such as https://www.projectbiglife.ca/

Considering you could put a try/catch around the toDataUrl(), or use the promise chain properly to catch the error, could I submit a PR with one of these approaches? I don't think this issue needs to be over thought, the core problem is your code generates an error and doesn't handle it.

[LaurenWags]

Verified with macOS 10.12.6 using

• 0.23.72 c3b1cac
• Muon 8.0.2
• libchromiumcontent 68.0.3440.75

Verified on Ubuntu 17.10 x64

• 0.23.72 c3b1cac
• Muon 8.0.2
• libchromiumcontent 68.0.3440.75

Verified on Windows x64 with
• 0.23.73 50bdb6d
• Muon 8.0.3
• libchromiumcontent 68.0.3440.75