Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab paging order is wrong with pinned tabs #149

Closed
bridiver opened this issue Jan 13, 2016 · 1 comment
Closed

Tab paging order is wrong with pinned tabs #149

bridiver opened this issue Jan 13, 2016 · 1 comment
Labels
bug/good-first-bug
Milestone
0.10.4dev

Comments

@bridiver
Copy link
Collaborator

Steps to reproduce:

  1. Open a tab and pin it
  2. Open a regular tab
  3. Open another tab and pin it
  4. use cmd-shift-[ or cmd-shift-] to cycle through tabs
    Order is based on creation order instead of actual position
@bbondy
Copy link
Member

bbondy commented Jan 14, 2016

was aware of this one, basically to fix we just need to always prepend all frames when we pin, instead of appending.

This was referenced May 2, 2016
Closed
Closed
@diracdeltas diracdeltas added this to the 0.9.4dev milestone May 2, 2016
@bbondy bbondy modified the milestones: 0.10.1dev, 0.10.0dev May 8, 2016
@bbondy bbondy modified the milestones: 0.10.1dev, 0.10.0dev May 18, 2016
@bbondy bbondy modified the milestones: 0.10.3dev, 0.10.1dev May 26, 2016
@stshank stshank mentioned this issue May 30, 2016
Closed
@luixxiul luixxiul mentioned this issue Jun 15, 2016
Merged
ayumi added a commit to ayumi/browser-laptop that referenced this issue Jun 15, 2016
@ayumi
Add frame display index and use for tab selection
5e304bb 
Fixes brave#1983 and brave#149
@bbondy bbondy modified the milestones: 0.10.4dev, 0.10.5dev Jun 15, 2016
@bbondy bbondy closed this as completed Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug
Projects
None yet
Milestone
0.10.4dev
Development

No branches or pull requests
3 participants
@bridiver @diracdeltas @bbondy