Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Two finger swipe for backwards/forwards does not work in C69 #15114

Closed
LaurenWags opened this issue Aug 29, 2018 · 3 comments
Closed

Two finger swipe for backwards/forwards does not work in C69 #15114

LaurenWags opened this issue Aug 29, 2018 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

On macOS you can use a gesture to go backwards and forwards in your page history. This is a two finger swipe which you do to either left or right. If the input is not registering, you can go into Advanced > Swipe Options to adjust the sensitivity

With the Chromium 69 upgrade, this functionality is not working

Steps to Reproduce

  1. Be on a laptop with a trackpad
  2. Open a tab and generate tab history by visiting sites or navigating around one site
  3. Go back in the tab history a few pages so you can go forward or backward
  4. Do two finger swipe from left to right (this should be going back) or right to left (this should be going forward)

Actual result:
Back/Forward arrows get larger to indicate you're trying to navigate, but the page does not change:

https://drive.google.com/file/d/1cSfVBdR62Ho7LjbJCr98bAdqXfMQ0kJR/view?usp=sharing

Expected result:
Should be able to navigate back and forth as we can on 0.23.104
swiping-023104

Reproduces how often:
easily

Brave Version

Brave: 0.23.201
V8: 6.9.427.17
rev: 17d2d17
Muon: 8.1.0
OS Release: 16.7.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 69.0.3497.57

Reproducible on current live release:
no

Additional Information

cc @kjozwiak to give it a try
Same thing happened on c65 update: #13433

@kjozwiak
Copy link
Member

Reproduced on my machine as well. The arrow animations seem to be working but the pages never actually switch when swiping. Double checked 0.23.104 and confirmed that it's working there. Looks like a C69 regression.

@darkdh darkdh self-assigned this Aug 29, 2018
darkdh added a commit that referenced this issue Aug 30, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
@darkdh
Copy link
Member

darkdh commented Aug 30, 2018

fixed by 69851d1

@darkdh darkdh closed this as completed Aug 30, 2018
darkdh added a commit that referenced this issue Aug 30, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
bsclifton pushed a commit that referenced this issue Aug 31, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 4, 2018

Verified with macOS 10.12.6 using

  • 0.23.203 16c2c19
  • Muon 8.1.2
  • libchromiumcontent 69.0.3497.72

Verified with macOS 10.12.6 x64 using the following build:

  • 0.23.203 16c2c19
  • Muon 8.1.2
  • libchromiumcontent 69.0.3497.72

Went through all the swipe speeds that are available under about:preferences#advanced and ensured they were working as expected.

bsclifton pushed a commit that referenced this issue Sep 11, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
bsclifton pushed a commit that referenced this issue Sep 14, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
bsclifton pushed a commit that referenced this issue Sep 18, 2018
only fire once each scroll since C69

mainly
fix #15114

also
fix #14871
fix #14829
fix #14785

Auditor: @bsclifton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.