JS Windows should be tab modal, not application modal

[garvankeeley]

Describe the issue you encountered:
Malicious sites will popup a JS modal dialog that blocks input, the browser has to be killed to close the window. You should be able to close the tab.

Expected behavior:
JS popup windows should be Tab-modal, not app-modal. Tab should be closable without interacting with the popup.

Mackeeper popups are an example of this.

[cezaraugusto]

@garvankeeley is anyone already working on it? /cc @diracdeltas

[diracdeltas]

cc @bridiver

[bridiver]

it's doable, be we'd have to rewrite electron's dialog handler to use an NSWindow instead of an NSAlert. afaik there is no way to make a non-window-modal NSAlert

[bridiver]

actually I take that back. The dialogs are initiated by ipc calls so there is no reason why we can't override and handle ourselves

[bridiver]

should also have a checkbox to prevent future dialog boxes for a site - bravery setting

[bsclifton]

@luixxiul this has been closed for some time, right? with #7107

[luixxiul]

I thought this hasn't, but you're right. thanks.