General Settings: "A new tab shows" setting #2106

bradleyrichter · 2016-06-07T00:12:24Z

Functionality:
"my new tab page"

shows the current version of a new tab page (blank white at time of writing)

"my home page"

shows the currently defined home page

"my default search engine"

shows the home page of the currently set default search engine

Item label:
"A new tab shows"

Menu choices:
"my new tab page"
"my home page"
"my default search engine"

menu snapshot:

Settings panel: (item for this issue shown in blue)

kingscott · 2016-06-24T21:37:49Z

Any chance this has been taken on? I just started the early stages of writing something of this sort. Any chance I could work on it or collaborate? @bradleyrichter

bradleyrichter · 2016-06-24T22:31:25Z

@kingscott We'd love to have your help!

This has not been started yet, besides what is currently implemented in today's release in the general prefs panel which is limited to startup, not a new tab view.

For code review, we can ask @bridiver or @bbondy .

kingscott · 2016-06-25T01:54:31Z

Great, thanks @bradleyrichter! I was jumping into it today at the end of my work day. Is that settings panel mentioned in the above image what has been agreed upon for production?

bradleyrichter · 2016-06-25T02:05:50Z

Hey @kingscott - I just updated it for you. But, please don't bother with the visual elements because we are currently working on a branch which is a complete prefs makeover.

We will have to merge your new code with the new UI work. Shouldn't be a problem...

If you want to take a look at the progress on that branch, here it is:

https://github.com/brave/browser-laptop/tree/cherry-picked-ui-updates

bradleyrichter · 2016-06-27T18:51:51Z

I’m all ears…

On Jun 27, 2016, at 10:45 AM, Scott King notifications@github.com wrote:

Hey @bradleyrichter https://github.com/bradleyrichter, just a quick opinion question for functionality. I have had a few ideas for this new tab stuff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #2106 (comment), or mute the thread https://github.com/notifications/unsubscribe/AM4jqqe4dYkyn7p1B_btu1xRt1rq8jq2ks5qQAwxgaJpZM4Ivb8W.

kingscott · 2016-06-27T19:38:37Z

Sorry about that, I had thought and didn't mean to write the comment (was trying to overcomplicate the task).

Also, did you want (or need) the new tab page created that has the tiles of previously visited pages?

bradleyrichter · 2016-06-28T03:25:27Z

@kingscott We would love the help on anything you are interested in working on. Here is a screen shot of the currently proposed "Top Sites/Info Page" but I haven't finished the details in the spec.

When you mouse-hover over the topsite thumbs, you would get the full page preview rendered behind the shadow masking:

There will be a neat UI to change the layout of the top site icons by clicking on a toggle button to change from 1, 2 or 3 rows, and a list view.

Let me know if this looks interesting to you...

Thanks!
Brad

kingscott · 2016-06-28T04:07:59Z

Wow, that looks really nice! Honestly - the top image looks awesome. I tend to prefer the more neutral images for new tab stuff.

Is that something you (Brave) would want me to build? In terms of the background, I do have a project I worked on that pulls in nice backgrounds. I have a Chrome extension for it as well. If that was of interest, I can extend and/or integrate with Brave. PS. It's in React as well.

EDIT: Just re-read the comment for the second picture - so disregard my second comment in the top paragraph. Sounds truly great 👍

bradleyrichter · 2016-06-29T00:27:51Z

Hey Scott - can I invite you to join our #community slack channel?

Also - I installed the chrome extension. Looks good. I think this is right up your alley. : )

kingscott · 2016-06-29T00:54:30Z

Sure, that would be great Brad!

bradleyrichter · 2016-06-30T00:41:26Z

@kingscott Just invited you as a contributor...

kingscott · 2016-06-30T03:48:31Z

Yes @bradleyrichter, I got it - thanks!

bsclifton · 2016-10-31T09:57:01Z

Original work done in PR #3488

- Add settings for new tab behaviour, handle this behaviour when you click the new tab button - Scaffolding for deafult search engine appearing as new tab - Grab proper search engine information on new tab - New tab can load default search engine - New tab can load default search engine - Add functionality for new tab options - Abstraction of handling new tab settings - Abstraction of handling new - Hopefully final abstraction to complete new tab functionality

@kingscott

Fixes #2106 - pulled out setting values into an enum - position moved to below "Brave starts with" (in preferences.js) - resolved circular dependency issue in appUrlUtil which broke app - made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live - defaultUrl removed from main.js (since it gets defaulted in windowStore.js) - removed defaultUrl from window.js (since windowStore.js also handles this) - put about pages into config; updated contextMenus.js to use config constants - adding missing "base" element to searchProviders that had it missing (mdn, github, startpage, etc) - updated defaultUrl logic in appUrlUtil.js to default unknown values to about:blank - windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl Auditors: @kingscott @cezaraugusto

- Add settings for new tab behaviour, handle this behaviour when you click the new tab button - Scaffolding for deafult search engine appearing as new tab - Grab proper search engine information on new tab - New tab can load default search engine - Add functionality for new tab options - Abstraction of handling new tab settings - Hopefully final abstraction to complete new tab functionality

@kingscott

Fixes #2106 - pulled out setting values into an enum - position moved to below "Brave starts with" (in preferences.js) - resolved circular dependency issue in appUrlUtil which broke app - made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live - defaultUrl removed from main.js (since it gets defaulted in windowStore.js) - removed defaultUrl from window.js (since windowStore.js also handles this) - put about pages into config; updated contextMenus.js to use config constants - adding missing "base" element to searchProviders that had it missing (mdn, github, startpage, etc) - updated defaultUrl logic in appUrlUtil.js to default unknown values to about:blank - windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl Auditors: @kingscott @cezaraugusto

- Add settings for new tab behaviour, handle this behaviour when you click the new tab button - Scaffolding for deafult search engine appearing as new tab - Grab proper search engine information on new tab - New tab can load default search engine - Add functionality for new tab options - Abstraction of handling new tab settings - Hopefully final abstraction to complete new tab functionality

@kingscott

Fixes #2106 - pulled out setting values into an enum - position moved to below "Brave starts with" (in preferences.js) - resolved circular dependency issue in appUrlUtil which broke app - made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live - defaultUrl removed from main.js (since it gets defaulted in windowStore.js) - removed defaultUrl from window.js (since windowStore.js also handles this) - put about pages into config; updated contextMenus.js to use config constants - adding missing "base" element to searchProviders that had it missing (mdn, github, startpage, etc) - updated defaultUrl logic in appUrlUtil.js to default unknown values to about:blank - windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl Auditors: @kingscott @cezaraugusto

- Add settings for new tab behaviour, handle this behaviour when you click the new tab button - Scaffolding for deafult search engine appearing as new tab - Grab proper search engine information on new tab - New tab can load default search engine - Add functionality for new tab options - Abstraction of handling new tab settings - Hopefully final abstraction to complete new tab functionality

@kingscott

Fixes #2106 Updated defaultUrl logic - windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl - default unknown values to about:blank Removed conflicting defaultUrl behavior (since it gets defaulted in windowStore.js) from: - main.js - window.js - tabs.js Misc - pulled out setting values into an enum - position moved to below "Brave starts with" (in preferences.js) - resolved circular dependency issue in appUrlUtil - adding missing "base" element to searchProviders that had it missing (mdn, github, startpage, etc) - made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live Auditors: @kingscott @cezaraugusto

@kingscott

Fixes #2106 Updated defaultUrl logic - windowStore.js now uses new defaultUrl method (from appUrlUtil) instead of config.defaultUrl - default unknown values to about:blank Removed conflicting defaultUrl behavior (since it gets defaulted in windowStore.js) from: - main.js - window.js - tabs.js Misc - pulled out setting values into an enum - position moved to below "Brave starts with" (in preferences.js) - resolved circular dependency issue in appUrlUtil - adding missing "base" element to searchProviders that had it missing (mdn, github, startpage, etc) - made a newtab option called BLANK and renamed value TEMP. We can change back when ready to go live Auditors: @kingscott @cezaraugusto

0xMF · 2016-11-16T13:53:02Z

Please bring back the empty New Tab option (applies to v. 0.12.9; win32; x64).

luixxiul · 2016-11-16T14:34:52Z

#5652 addressed the issue but I would have to say I preferred the option than leaving the home page URL empty.

bradleyrichter added the settings label Jun 7, 2016

bradleyrichter added this to the 0.11.0dev milestone Jun 7, 2016

bradleyrichter added the documentation ✍ label Jun 7, 2016

bradleyrichter removed this from the 0.11.0dev milestone Jun 30, 2016

bradleyrichter assigned kingscott Jun 30, 2016

bbondy mentioned this issue Jul 9, 2016

Ability to customize the new tab page #1363

Closed

kingscott mentioned this issue Aug 27, 2016

[WIP] Add settings for new tab behaviour #3488

Closed

9 tasks

bsclifton self-assigned this Oct 31, 2016

bsclifton mentioned this issue Nov 1, 2016

Brand new about:newtab page #5301

Merged

4 tasks

bsclifton added this to the 0.12.8dev milestone Nov 1, 2016

bbondy closed this as completed in #5301 Nov 1, 2016

luixxiul added the feature/newtab label Nov 1, 2016

This was referenced Nov 2, 2016

Manual tests for OS X 0.12.8 Preview3 #5358

Closed

Manual tests for Ubuntu 0.12.8 Preview3 #5359

Closed

Manual tests for Windows x64 0.12.8 Preview3 #5360

Closed

srirambv modified the milestones: 0.12.9dev, 0.12.8dev Nov 3, 2016

srirambv added the QA/checked-Win64 label Nov 11, 2016

alexwykoff mentioned this issue Nov 14, 2016

Manual tests for OS X 0.12.9 Preview 3 Per-release Items #5591

Closed

alexwykoff added the QA/checked-macOS label Nov 14, 2016

This was referenced Nov 14, 2016

Manual tests for Window x64 0.12.9 Preview 3 per-release items #5597

Closed

Manual tests for Ubuntu 0.12.9 Preview 3 per-release items #5598

Closed

luixxiul mentioned this issue Nov 14, 2016

Manual tests for Window ia-32 0.12.9 RC1 per-release items #5604

Closed

srirambv added the QA/checked-Linux label Nov 15, 2016

This was referenced Nov 16, 2016

prefs: make empty home page address = about:blank #5652

Closed

Create "Empty New Tab" option in General Settings #5682

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General Settings: "A new tab shows" setting #2106

General Settings: "A new tab shows" setting #2106

bradleyrichter commented Jun 7, 2016 •

edited

Loading

kingscott commented Jun 24, 2016

bradleyrichter commented Jun 24, 2016

kingscott commented Jun 25, 2016

bradleyrichter commented Jun 25, 2016

bradleyrichter commented Jun 27, 2016

kingscott commented Jun 27, 2016

bradleyrichter commented Jun 28, 2016

kingscott commented Jun 28, 2016 •

edited

Loading

bradleyrichter commented Jun 29, 2016

kingscott commented Jun 29, 2016

bradleyrichter commented Jun 30, 2016

kingscott commented Jun 30, 2016

bsclifton commented Oct 31, 2016

0xMF commented Nov 16, 2016

luixxiul commented Nov 16, 2016

General Settings: "A new tab shows" setting #2106

General Settings: "A new tab shows" setting #2106

Comments

bradleyrichter commented Jun 7, 2016 • edited Loading

kingscott commented Jun 24, 2016

bradleyrichter commented Jun 24, 2016

kingscott commented Jun 25, 2016

bradleyrichter commented Jun 25, 2016

bradleyrichter commented Jun 27, 2016

kingscott commented Jun 27, 2016

bradleyrichter commented Jun 28, 2016

kingscott commented Jun 28, 2016 • edited Loading

bradleyrichter commented Jun 29, 2016

kingscott commented Jun 29, 2016

bradleyrichter commented Jun 30, 2016

kingscott commented Jun 30, 2016

bsclifton commented Oct 31, 2016

0xMF commented Nov 16, 2016

luixxiul commented Nov 16, 2016

bradleyrichter commented Jun 7, 2016 •

edited

Loading

kingscott commented Jun 28, 2016 •

edited

Loading