Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't show an option to pin about:blank and about:newtab #2253

Closed
bbondy opened this issue Jun 21, 2016 · 4 comments
Closed

Don't show an option to pin about:blank and about:newtab #2253

bbondy opened this issue Jun 21, 2016 · 4 comments
Labels
bug/good-first-bug polish Nice to have — usually related to front-end/visual tasks.
Milestone
0.11.0dev

Comments

@bbondy
Copy link
Member

bbondy commented Jun 21, 2016

Do not show an option to pin for about:blank, about:newtab and also not if isIntermediateAboutPage is true from appUrlUtil
@bbondy bbondy added polish Nice to have — usually related to front-end/visual tasks. bug/good-first-bug labels Jun 21, 2016
@rifazn
Copy link

rifazn commented Jun 25, 2016

Could you tell me which file this bug relates to?
I'd just like to play around with it a bit. See if I can put a good change or two.

darkdh added a commit to darkdh/browser-laptop that referenced this issue Jun 26, 2016
@darkdh
Don't show an option to pin about:blank and about:newtab
7035500 
Fix brave#2253
@darkdh darkdh mentioned this issue Jun 26, 2016
Merged
3 tasks
@darkdh
Copy link
Member

darkdh commented Jun 26, 2016 •
edited
Loading

Sorry, I didn't see @rifazn's comment and I forgot to take it first.

@bbondy
Copy link
Member Author

bbondy commented Jun 27, 2016

No worries and thanks for the PR @darkdh!

@rifazn would you mind if we took @darkdh's pull request and you worked on something else? Sorry we were slow to respond on this one on the weekend @rifazn.

@rifazn
Copy link

rifazn commented Jun 27, 2016

Hey it's no problem. ;)

This was referenced Jun 29, 2016
Closed
Closed
@luixxiul luixxiul added this to the 0.10.5dev milestone Jun 30, 2016
This was referenced Jun 30, 2016
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.11.0dev
Development

No branches or pull requests
4 participants
@bbondy @rifazn @luixxiul @darkdh