Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dragging texts, crashes the browser #2328

Closed
Kzeir opened this issue Jun 29, 2016 · 21 comments
Closed

Dragging texts, crashes the browser #2328

Kzeir opened this issue Jun 29, 2016 · 21 comments
Labels
bug crash misc/drag-and-drop needs-info Another team member needs information from the PR/issue opener.

Comments

@Kzeir
Copy link

Kzeir commented Jun 29, 2016

When I drag some text, even for acident, the browser crashes and restart, and I lost some pages that I was open.

I search for similars and I didn't find so...

  • Platform Win 10
  • Brave Version:
    0.10.4
@luixxiul
Copy link
Contributor

I experience this sometimes. Not sure steps to reproduce

@Kzeir
Copy link
Author

Kzeir commented Jun 30, 2016

My browser sometime crash, when I select a text with the cursor, and drag
it, just a little...

Att: Alessandro Tetsuo More

2016-06-30 7:32 GMT-03:00 Suguru Hirahara notifications@github.com:

I experience this sometimes. Not sure steps to reproduce


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2328 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AQvmEkqt1eCPcOIhzrQEvST3a30IlHFnks5qQ5s3gaJpZM4JAvb0
.

@Kzeir
Copy link
Author

Kzeir commented Jul 6, 2016

Seems been fixed, in this new update 0.11.0

@luixxiul
Copy link
Contributor

luixxiul commented Jul 6, 2016

OK, let's see it was really fixed...

@Kzeir
Copy link
Author

Kzeir commented Jul 6, 2016

No, Still there. I was in the messenger.com and drag a text by acident and the browser crashed.

@luixxiul luixxiul added the bug label Jul 6, 2016
@pixelass
Copy link

This happens to me a lot when I try to cancel a click on a link.

Reproduce:

  1. mousedown on link
  2. move away from link
  3. mouseup outside link

Expected behavior:

Nothing should happen. The link should not be triggered.

This happens

The browser crashes

Versions

OS X Sierra | 10.12.1 (16B2555)
Brave desktop | 0.12.14

@luixxiul luixxiul added this to the Backlog milestone Jan 5, 2017
@srirambv
Copy link
Collaborator

srirambv commented Feb 3, 2017

Still an issue with 0.13.1

Click and drag a highlighted URL causes the webview to crash. Most easily reproducible(but not always) .

This is what happened to me on 0.13.1

  1. Highlight text on a webpage/pdf, click and drag the highlighted text which causes the webview renderer to crash(Blank white screen)
  2. Close the browser and reopen, all tabs and history gone but retains bookmarks and settings
  3. session-store-1 file which was ~200KB before the render crash is now 22KB

This should be addressed at least by 1.0 as users can loose their entire session data if this happens. @bbondy thoughts.

@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

I think probably the session storage thing is just that it didn't auto save yet since you did an import? Probably if it saved at least once then it would be preserved. Same as if you import and directly crash fast.

@pixelass
Copy link

pixelass commented Feb 3, 2017

This was my main reason why I stopped using brave. dragging resulted in a loss of everything that was open or saved in brave's cache. I tried several approaches to at least get an updated version after a crash but eventually gave up.

@pixelass
Copy link

pixelass commented Feb 3, 2017

I now use brave for issue testing only.
Happy to test and reproduce this issue if more info is given.

@luixxiul
Copy link
Contributor

luixxiul commented Feb 6, 2017

From my experience the issue only has happened when the link was dragged and dropped fast (by accident). When I dragged and dropped the link slowly, I could not reproduce the issue.

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Feb 6, 2017
@pixelass
Copy link

pixelass commented Feb 6, 2017 via email

@luixxiul
Copy link
Contributor

luixxiul commented Feb 6, 2017

Thanks for report. Then the speed does not matter here.

@alexwykoff
Copy link
Contributor

I have tried to repro with 0.13.5 preview 3 to no avail.
I used OS X and a trackpad.

Perhaps there is a confounding factor we did take into account?
Having a specific site which reproduces for others would be helpful.

@bbondy bbondy modified the milestones: 0.13.6, Backlog Mar 13, 2017
@jonathansampson
Copy link
Collaborator

I also cannot repro on Windows, running 0.13.5 :(

@bsclifton
Copy link
Member

moving to 0.13.7

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 14, 2017
@bsclifton
Copy link
Member

moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 5, 2017
@cndouglas
Copy link

Perhaps this was fixed with #7266.

@luixxiul
Copy link
Contributor

luixxiul commented Apr 7, 2017

#7266 is related with only macOS while the error happens on Windows.

@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 7, 2017
@jonathansampson
Copy link
Collaborator

@bsclifton I vote we close this. I cannot repro via any of the above STR.

@bsclifton
Copy link
Member

@jonathansampson ++ on that

If you're reading this and experiencing the above symptoms, please comment or reopen the issue. Thanks 😄

@bsclifton bsclifton removed this from the 0.14.3 milestone Apr 10, 2017
@cndouglas cndouglas removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 11, 2017
@bsclifton bsclifton added the needs-info Another team member needs information from the PR/issue opener. label Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug crash misc/drag-and-drop needs-info Another team member needs information from the PR/issue opener.
Projects
None yet
Development

No branches or pull requests

9 participants