Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fingerprinting and "notifications showing twice" automated tests are failing #2370

Closed
bbondy opened this issue Jul 2, 2016 · 3 comments
Closed

Fingerprinting and "notifications showing twice" automated tests are failing #2370

bbondy opened this issue Jul 2, 2016 · 3 comments
Labels
automated-tests QA/checked-macOS QA/no-qa-needed QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 2, 2016 •
edited by luixxiul
Loading

Test plan

npm run test -- --grep='does not show the same notification twice'

https://travis-ci.org/brave/browser-laptop/builds/141841305

I haven't checked if it's intermittent or not.
cc @diracdeltas
diracdeltas added a commit that referenced this issue Jul 6, 2016
@diracdeltas
Run persistent notification bar test last
9091cd9 
Otherwise once the permission is set, future notifications for the
same permission will not be shown.

Partial fix for #2370

Auditors: @bbondy
@luixxiul luixxiul added the tests label Jul 8, 2016
@luixxiul luixxiul modified the milestones: 0.13.2, 0.13.1, 0.13.3 Jan 29, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Feb 1, 2017

the milestone was reset to 0.13.3

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul added this to the 0.15.400 milestone May 15, 2017
@diracdeltas
Copy link
Member

seems these are fixed now https://travis-ci.org/brave/browser-laptop/jobs/233773486

@alexwykoff
Copy link
Contributor

Yep, if it's broken we can reopen

@alexwykoff alexwykoff removed this from the 0.16.100 milestone May 23, 2017
@luixxiul luixxiul added this to the 0.15.300 milestone May 23, 2017
This was referenced May 25, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-tests QA/checked-macOS QA/no-qa-needed QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@diracdeltas @bbondy @alexwykoff @luixxiul