Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

prefs that require browser restart should show prompt for browser restart #2543

Closed
diracdeltas opened this issue Jul 17, 2016 · 3 comments
Closed

prefs that require browser restart should show prompt for browser restart #2543

diracdeltas opened this issue Jul 17, 2016 · 3 comments
Assignees
@darkdh
Labels
bug/good-first-bug QA/checked
Milestone
0.11.2dev

Comments

@diracdeltas
Copy link
Member

There are a bunch of prefs in about:preferences that require browser restart. If they are changed, Brave should show a notification bar that says, 'Do you want to restart now?' and restart when 'Yes' is clicked.
@diracdeltas diracdeltas added this to the 0.11.2dev milestone Jul 17, 2016
@luixxiul
Copy link
Contributor

This should close #1705 as well.

@darkdh darkdh self-assigned this Jul 17, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Jul 17, 2016
@darkdh
prefs that require browser restart should show prompt for browser res…
5b37100 
…tart

fix brave#2543
@darkdh darkdh mentioned this issue Jul 17, 2016
Closed
3 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Jul 17, 2016
@darkdh
prefs that require browser restart should show prompt for browser res…
897dddc 
…tart

fix brave#2543
darkdh added a commit to darkdh/browser-laptop that referenced this issue Jul 18, 2016
@darkdh
prefs that require browser restart should show prompt for browser res…
e14c9df 
…tart

fix brave#2543
@bbondy bbondy modified the milestones: 0.11.2dev, 0.11.3dev Jul 21, 2016
@luixxiul
Copy link
Contributor

I thought this also fixed #1705, but seems it didn't.

@luixxiul
Copy link
Contributor

Also IMO the notification bar should be displayed only on about:preferences and closed automatically if setting is restored right away.

@luixxiul luixxiul modified the milestones: 0.11.2dev, 0.11.3dev Jul 27, 2016
This was referenced Jul 29, 2016
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 2, 2016
Closed
Closed
This was referenced Aug 3, 2016
Closed
Closed
Closed
Closed
This was referenced Aug 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug/good-first-bug QA/checked
Projects
None yet
Milestone
0.11.2dev
Development

Successfully merging a pull request may close this issue.

prefs that require browser restart should show prompt for browser restart darkdh/browser-laptop
5 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @darkdh