Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add delete confirmation to downloads bar #2604

Closed
luixxiul opened this issue Jul 20, 2016 · 7 comments
Closed

Add delete confirmation to downloads bar #2604

luixxiul opened this issue Jul 20, 2016 · 7 comments
Labels
bug/good-first-bug feature/download parity Features which should be supported in Brave since they're supported in other major browsers. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 20, 2016 •
edited by bsclifton
Loading

Test Plan

  • Download a file
  • try to delete it from the downloadsBar
  • notice new confirmation bar
    • click ok to remove the file
    • move the mouse outside the downloadItem panel to hide the confirmation bar.

Original issue description

"Delete Download" on download bar should have a warning prompt.
@stan-qaz
Copy link

An additional reason to add a confirmation here is because when downloading and you open the status-bar download box the "open in folder" is the last icon shown at the right. When the download completes the first icon on the left, "pause", is removed and a "delete" icon is added on the far right. This effectively replaces the "open in folder" icon with the "delete" icon in the same spot and nearly instantly when the remaining icons shift left to fill the hole left by the removal of the "pause" icon.

Maybe change the icon order so that the pause is replaced by the delete, in the far left location, until the confirmation option is available?

On the other hand it is nice to see that the delete icon can quickly remove a 4 GB ISO download that has just finished. :-(

@luixxiul
Copy link
Contributor Author

This effectively replaces the "open in folder" icon with the "delete" icon in the same spot

wdyt @bradleyrichter ? I noticed this too.

@willy-b
Copy link
Contributor

willy-b commented Nov 27, 2016 via email

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 27, 2016 •
edited
Loading

How about something like this? (l10n friendly)

image

@stan-qaz
Copy link

That would solve my problem completely and it looks pretty sharp too.

@cndouglas
Copy link

Solution: #5969

@bsclifton
Copy link
Member

from #5969, here are the acceptance criteria per @bradleyrichter:

Deleting files is destructive and can not be undone. Thus, it needs a minimal confirmation.

Adding this to the delete bar UI keeps the confirmation focused at the point of interaction rather than opening a dialog.

To cancel, click outside of the popup box.

image

@bsclifton bsclifton added design A design change, especially one which needs input from the design team. enhancement parity Features which should be supported in Brave since they're supported in other major browsers. labels Dec 3, 2016
@bsclifton bsclifton added this to the 1.0.0 milestone Dec 3, 2016
@bsclifton bsclifton mentioned this issue Dec 3, 2016
Closed
@bsclifton bsclifton changed the title "Delete Download" on download bar should have a warning prompt Add delete confirmation to downloads bar Dec 3, 2016
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 4, 2017
@michalbe
Download Item Removal Confirmation
4d5f6b2 
Fixes brave#2604
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 4, 2017
@michalbe
Download Item Removal Confirmation
4f955d6 
Fixes brave#2604
@michalbe michalbe mentioned this issue Feb 4, 2017
Merged
4 tasks
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 5, 2017
@michalbe
Download Item Removal Confirmation
36f7cd8 
Fixes brave#2604
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 5, 2017
@michalbe
Download Item Removal Confirmation
429d766 
Fixes brave#2604
@luixxiul luixxiul modified the milestones: 0.13.3, 1.0.0 Feb 5, 2017
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 5, 2017
@michalbe
Download Item Removal Confirmation
4e71f1d 
Fixes brave#2604
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 5, 2017
@michalbe
Download Item Removal Confirmation
2b60d47 
Fixes brave#2604
bsclifton pushed a commit to michalbe/browser-laptop that referenced this issue Feb 14, 2017
@michalbe @bsclifton
Download Item Removal Confirmation
b26b84a 
Fixes brave#2604
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 14, 2017
@michalbe
Download Item Removal Confirmation
eec85c8 
Fixes brave#2604

Updated test to handle confirm click
- rename downloadDeleteConfirmationVisible to deleteConfirmationVisible
- wrap spy code with try/finally to ensure proper cleanup
- confirmDeleteButton is checked independently from deleteButton

Auditors: @michalbe
bsclifton pushed a commit to michalbe/browser-laptop that referenced this issue Feb 15, 2017
@michalbe @bsclifton
Download Item Removal Confirmation
6111569 
Fixes brave#2604

Updated test to handle confirm click
- rename downloadDeleteConfirmationVisible to deleteConfirmationVisible
- wrap spy code with try/finally to ensure proper cleanup
- confirmDeleteButton is checked independently from deleteButton

Auditors: @michalbe
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 15, 2017
@michalbe
Download Item Removal Confirmation
97f96bd 
Fixes brave#2604

Updated test to handle confirm click
- rename downloadDeleteConfirmationVisible to deleteConfirmationVisible
- wrap spy code with try/finally to ensure proper cleanup
- confirmDeleteButton is checked independently from deleteButton

Auditors: @michalbe
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 15, 2017
@michalbe
Download Item Removal Confirmation
c5026e5 
Fixes brave#2604

Updated test to handle confirm click
- rename downloadDeleteConfirmationVisible to deleteConfirmationVisible
- wrap spy code with try/finally to ensure proper cleanup
- confirmDeleteButton is checked independently from deleteButton

Auditors: @michalbe
@bsclifton bsclifton added QA/test-plan-specified release-notes/include and removed design A design change, especially one which needs input from the design team. labels Feb 16, 2017
This was referenced Feb 26, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug feature/download parity Features which should be supported in Brave since they're supported in other major browsers. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
9 participants
@bbondy @alexwykoff @stan-qaz @luixxiul @bsclifton @willy-b @bradleyrichter @srirambv @cndouglas