Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Typing in URL bar fast can be laggy #2736

Closed
bbondy opened this issue Jul 27, 2016 · 1 comment · Fixed by #2849
Closed

Typing in URL bar fast can be laggy #2736

bbondy opened this issue Jul 27, 2016 · 1 comment · Fixed by #2849
Labels
feature/URLbar perf QA/checked
Milestone
0.11.2dev

Comments

@bbondy
Copy link
Member

bbondy commented Jul 27, 2016

I don't reproduce this myself but Brendan does. If you type in the URL bar it can lag. This could probably be fixed by profiling and just optimizing things around keydown in the urlbar.
@bbondy bbondy added this to the 0.11.2dev milestone Jul 27, 2016
bbondy added a commit that referenced this issue Jul 29, 2016
@bbondy
Cache current window
8d43481 
ipcRenderer does sync IPC on each access to getCurrentWindow() this leads to about 30% of the time when typing in the URL bar being used there (the highest function). After this change it goes to 4% for ipcRenderer when typing in the URLbar.

This helps #2736, but I'll do some more investigating for more optimizations

Auditors: @bridiver
@bbondy
Copy link
Member Author

bbondy commented Jul 31, 2016

Various pref improvements here:
https://github.com/brave/browser-laptop/commits/perf

@bbondy bbondy mentioned this issue Aug 2, 2016
Merged
This was referenced Aug 2, 2016
Closed
Closed
This was referenced Aug 2, 2016
Closed
Closed
This was referenced Aug 3, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@diracdeltas diracdeltas mentioned this issue Sep 28, 2016
Closed
@luixxiul luixxiul added the perf label Sep 30, 2016
@cndouglas cndouglas mentioned this issue Jan 13, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/URLbar perf QA/checked
Projects
None yet
Milestone
0.11.2dev
Development

Successfully merging a pull request may close this issue.

Perf brave/browser-laptop
4 participants
@bbondy @alexwykoff @luixxiul @cndouglas