Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Start searching bookmarks as soon as characters are typed #2778

Closed
luixxiul opened this issue Jul 29, 2016 · 3 comments
Closed

Start searching bookmarks as soon as characters are typed #2778

luixxiul opened this issue Jul 29, 2016 · 3 comments
Labels
bug/good-first-bug feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 29, 2016 •
edited
Loading

Describe the issue you encountered: It should be nice if bookmark search is started when I type characters on about:bookmarks. I have to select the input field first to start searching

Expected behavior:
@bbondy bbondy added bug/good-first-bug polish Nice to have — usually related to front-end/visual tasks. and removed suggestion labels Jul 29, 2016
@MKuenzi
Copy link
Contributor

MKuenzi commented Sep 16, 2016

Can anyone point me to guidance on debugging the react components?

@bbondy
Copy link
Member

bbondy commented Sep 18, 2016

https://github.com/brave/browser-laptop/blob/master/docs/debugging.md

@bbondy
Copy link
Member

bbondy commented Sep 18, 2016

You wan the shift+f8 dev tools which will allow you to set breakpoints in the code.

MKuenzi added a commit to MKuenzi/browser-laptop that referenced this issue Sep 18, 2016
@MKuenzi
Search bookmarks as soon as characters are typed
dbcb0f1 
Fixes brave#2778
MKuenzi added a commit to MKuenzi/browser-laptop that referenced this issue Sep 18, 2016
@MKuenzi
Search bookmarks as soon as characters are typed
039aef0 
Fixes brave#2778
@MKuenzi MKuenzi mentioned this issue Sep 18, 2016
Merged
4 tasks
@bbondy bbondy added this to the 0.12.2dev milestone Sep 19, 2016
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
@arsalankhalid arsalankhalid mentioned this issue Apr 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

No branches or pull requests
7 participants
@aekeus @bbondy @alexwykoff @luixxiul @bsclifton @MKuenzi @srirambv