Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Closing an inactive tab should not change the active tab #2913

Closed
gulkily opened this issue Aug 3, 2016 · 4 comments
Closed

Closing an inactive tab should not change the active tab #2913

gulkily opened this issue Aug 3, 2016 · 4 comments
Milestone

Comments

@gulkily
Copy link

gulkily commented Aug 3, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When an inactive tab is closed by clicking the X button, the active tab changes to the closed tab's opener.

Expected behavior:
The active tab should remain the same.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.1
  • Steps to reproduce:
    1. Open a page that has 2 or more links on it
    2. Open at least 2 links, each in a new tab
    3. Switch to one of the opened tabs
    4. Close the other tab by hovering the tab, waiting for the X button to appear, and clicking the X button.

Expected: The active tab remains the same

Actual: The first tab becomes the active tab

@willy-b
Copy link
Contributor

willy-b commented Aug 4, 2016

Adding quick illustration of how to reproduce original bug, since it is sensitive to tab order:

taberror_final

bsclifton added a commit that referenced this issue Aug 6, 2016
Fixes #2913: Closing an inactive tab should not change the active tab
@gulkily
Copy link
Author

gulkily commented Aug 8, 2016

This is still a bug in 0.11.3. Should I be using a daily build to verify?

@luixxiul
Copy link
Contributor

luixxiul commented Aug 8, 2016

@gulkily yes, you need to build the binary by yourself to verify it's fixed.

@gulkily
Copy link
Author

gulkily commented Aug 16, 2016

Verified fixed in 0.11.5!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants