Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Font rendering and "lang" attribute #2929

Closed
luixxiul opened this issue Aug 4, 2016 · 5 comments
Closed

Font rendering and "lang" attribute #2929

luixxiul opened this issue Aug 4, 2016 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 4, 2016

Describe the issue you encountered:
Font rendering is poor in Japanese if "lang" attribute is not set properly in html tag.

clipboard01

Japanese and Chinese fonts are mixed here. For example "しています" rendered in Japanese fonts, while the font for "説明" is in Chinese (Taiwan) fonts.

Basically this bug seems to be like https://bugs.chromium.org/p/chromium/issues/detail?id=422180 "Chinese font selected under Japanese locale on Android".

Because this bug does not occur on Chrome, we should be able to fix this.

Expected behavior: It should be like this:
clipboard01

  • Platform (Win7, 8, 10? macOS? Linux distro?):
  • Brave Version:
  • Steps to reproduce:
    1. Open https://braveinfo.net
    2. Open Devtool
    3. Change font-family to Arial for :root
    4. Replace lang="ja" into lang="en"
  • Screenshot if needed:
  • Any related issues: Localization tracking bug #1858
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 6, 2016

This applies not only page rendering, but also frame rendering.
clipboard01

  1. Make sure any Japanese fonts are installed on your machine
  2. Open Devtool with Shift+F8
  3. Change en-US of html lang into ja-JP en-US

This makes it into this, which looks consistent:
clipboard01

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 6, 2016

The issue seems to be specific to Windows. On macOS it looks fine. I did not test on Linux.

@luixxiul
Copy link
Contributor Author

It seems this was fixed with the latest cr54.

@bridiver do you have any info on this?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Dec 20, 2016
@bridiver
Copy link
Collaborator

this was probably related to the general locale issues so it would have been fixed by brave/muon@d4f451c

@luixxiul
Copy link
Contributor Author

Test plan: available on the 1st post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants