Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Localization tracking bug #1858

Closed
luixxiul opened this issue May 22, 2016 · 7 comments
Closed

Localization tracking bug #1858

luixxiul opened this issue May 22, 2016 · 7 comments
Assignees
Labels

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 22, 2016

Describe the issue you encountered: Although .properties files were translated on transifex and downloaded in the locale folder, some parts of the UI remain English.

Expected behavior: Every string which was translated should be displayed in the language, as soon as the translation files are found/renewed in the locales folder.

  • Platform (Win7, 8, 10? OS X? Linux distro?): Ubuntu
  • Brave Version: Master branch
  • Steps to reproduce:
    1. Download .properties files of the translation from transifex
    2. Change the language setting into another language, for example Japanese
    3. Restart
    4. Download something
  • Screenshot if needed:

What remains in English:

  • "New"
  • "Zoom"
  • "New Tab"
  • Urlbar placeholder
  • "About Brave"

Any related issues: #1659

@luixxiul
Copy link
Contributor Author

luixxiul commented May 22, 2016

I found that concerning "About Brave" the string was not translated in Japanese yet due to the grammatical difference. See #1659 and menu.properties#L119. Some work on commonMenu.js#L297 is needed to combine "About" and app.name into one string.

@aekeus aekeus self-assigned this May 24, 2016
@luixxiul
Copy link
Contributor Author

I have partly addressed the issue with #2629, #2612, #2597. Still there may be some others.

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 23, 2016

"New" and "Zoom" have been translated but not applied due to a bug #2638

@luixxiul luixxiul added this to the 0.11.2dev milestone Jul 23, 2016
@bbondy bbondy modified the milestones: 0.11.3dev, 0.11.2dev Jul 28, 2016
@bbondy
Copy link
Member

bbondy commented Jul 28, 2016

Would like this soon but moving to 0.11.3 for now. @luixxiul pls revolt if this was working on a previous version of Brave.

@bbondy bbondy modified the milestones: 0.11.4dev, 0.11.6dev, 0.11.5dev Aug 9, 2016
@bbondy
Copy link
Member

bbondy commented Aug 13, 2016

I think this can be closed now, if so please re-set the milestone to nothing and close.

@luixxiul
Copy link
Contributor Author

OK, let me check later

@luixxiul
Copy link
Contributor Author

I confirmed #2638 was fixed, thank you @bridiver and @aekeus.

I found some untranslatable labels in contextMenus.js. WIll push a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants