Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

passwords.properties not loaded #3946

Closed
luixxiul opened this issue Sep 13, 2016 · 3 comments
Closed

passwords.properties not loaded #3946

luixxiul opened this issue Sep 13, 2016 · 3 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 13, 2016

Describe the issue you encountered: passwords.properties is not applied.

Expected behavior: It should be loaded.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: master branch
  • Screenshot if needed:

screenshot 2016-09-13 15 07 58

- Any related issues: #3671 #1858
@luixxiul luixxiul added the l10n label Sep 13, 2016
@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

there is no password.properties only a passwords.properties

@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

found it we aren't using the translated string,

@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

I don't think we have a way to dynamically get strings in about: pages yet.

data-l10n-id works there, but the string that need to get the value dynamically I think don't:
https://github.com/brave/browser-laptop/blob/master/js/about/passwords.js#L137

It needs to use confirmClearPasswords

/cc @aekeus @bridiver

@bbondy bbondy added this to the 0.12.2dev milestone Sep 13, 2016
@luixxiul luixxiul changed the title password.properties not loaded passwords.properties not loaded Sep 13, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 17, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.3dev Sep 26, 2016
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 10, 2016
@bbondy bbondy removed this from the 0.12.6dev milestone Oct 18, 2016
@luixxiul luixxiul added this to the 1.1.0 milestone Nov 20, 2016
@luixxiul luixxiul added the bug label May 28, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants