Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Release note link texts should be l10n-friendly #8162

Closed
luixxiul opened this issue Apr 10, 2017 · 9 comments
Closed

Release note link texts should be l10n-friendly #8162

luixxiul opened this issue Apr 10, 2017 · 9 comments

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: https://github.com/srirambv/browser-laptop/blob/07a49902262239d8c1f0872e2129a39811e45599/js/about/brave.js#L52-L56

Release note link texts should be l10n-friendly.

  1. Remove  s (not every language has whitespaces)
  2. Replace the link with a variable to let localizers decide where to put it

I wish @liunkae has some ideas to fix the issue (replace the variable for Transifex with a function, etc)

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 10, 2017

If you are not familiar with the editor on transifex, here is a part of the list which contains untranslated strings:

clipboard01

Just translating each word does not make sense in a sentence due to grammatical difference.

They actually should be in one sentence: Click {{here}} to view the release notes and let translators decide how to handle the variable.

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 10, 2017

The way the strings are placed has the issue on not only Japanese but also German: #8177.

FYI in Japanese, in order to localize with the current sets, they need to be placed like this:

To view the release notes, {{ here }} click.

リリースノートを見るには, {{ここ}}をクリックしてください。

The way the strings are aligned are completely reversed.

@cndouglas
Copy link

cndouglas commented Apr 10, 2017

Edit: Removed other example of the problem already covered by #5733.

Here's my idea for a solution:
Use two strings:

  1. Click {{here}} to view the release notes.
  2. here

The translator can choose where to place the link (1) and what the link text should be (2).

In code, we create a localized link with (2) and replace {{here}} in (1) with the link.

For example, in Japanese, the translated strings would look like this:

  1. リリースノートを見るには, {{here}}をクリックしてください。
  2. ここ

@luixxiul
Copy link
Contributor Author

@liunkae if that works that would be a nice solution :-)

@bsclifton
Copy link
Member

@luixxiul it should work great 😄 Here's a demo of where @liunkae did it with regards to Pocket:
https://github.com/brave/browser-laptop/pull/8110/files

Although, this goes a step further by using a translated string as an argument... which should still work great 😄

@luixxiul
Copy link
Contributor Author

@liunkae If you would not mind taking this in the way you prefer, would you please consider taking #4102 and #5733? that would be very helpful!

@cndouglas
Copy link

@luixxiul Sure, I'll try.

@cndouglas cndouglas self-assigned this Apr 11, 2017
@cndouglas
Copy link

Two problems: I can't seem to replace {{here}} with the link React component, and I'm running into #3946. Not sure how to proceed. 😕

@cndouglas
Copy link

I can't find a way to fix this without the ability to dynamically get translated strings. I'll try fixing this problem once #3946 is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants