Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Localization of Pepper Flash instruction on about:preferences#security #5733

Closed
luixxiul opened this issue Nov 19, 2016 · 1 comment
Closed

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 19, 2016

Describe the issue you encountered:

This is essentially the same issue as #4102

This part of Pepper Flash instruction on about:preferences#security should be localizable in languages whose grammar is different from English:

<span><span data-l10n-id='flashTroubleshooting' />&nbsp;
<span className='linkText' onClick={aboutActions.newFrame.bind(null, {
location: 'https://github.com/brave/browser-laptop/wiki/Flash-Support-Deprecation-Proposal#troubleshooting-flash-issues'
}, true)}>{'wiki'}</span>.</span>

Because the link to Flash installer cannot be moved, I had to hack the localization on Transifex against the grammar of Japanese (which does not have whitespaces and colons) to make it like this:

clipboard01

Expected behavior:

To make the sencense be globally localizable,

  1. Remove &nbsp; on
    <span><span data-l10n-id='flashTroubleshooting' />&nbsp;
  2. Make the link to Flash installer a variable
  3. Remove . on
    }, true)}>{'wiki'}</span>.</span>

and let translators on Transifex decide how to handle them.

--

@luixxiul luixxiul added this to the 1.1.0 milestone Nov 19, 2016
@luixxiul luixxiul modified the milestones: contributor backlog, 1.1.0 Dec 23, 2016
@luixxiul luixxiul removed this from the contributor backlog milestone Apr 10, 2017
@cndouglas cndouglas self-assigned this Apr 11, 2017
@cndouglas
Copy link

See #8162 (comment)

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants