Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

passwords.properties not being loaded at app level #3671

Closed
bbondy opened this issue Sep 2, 2016 · 6 comments
Closed

passwords.properties not being loaded at app level #3671

bbondy opened this issue Sep 2, 2016 · 6 comments
Assignees
Milestone

Comments

@bbondy
Copy link
Member

bbondy commented Sep 2, 2016

Noticed this error while debugging the browser process

@bbondy bbondy added this to the 0.11.7dev milestone Sep 2, 2016
@bbondy bbondy closed this as completed in f386c1c Sep 2, 2016
@alexwykoff
Copy link
Contributor

Anything for QA to check with this?

@alexwykoff
Copy link
Contributor

From the commit:
Test Plan: Make sure password strings can be localized, not needed once per platform just @luixxiul can verify

@luixxiul
Copy link
Contributor

luixxiul commented Sep 6, 2016

It seems that passwords.properties is not applied correctly.

clipboard01

@luixxiul luixxiul reopened this Sep 6, 2016
@bbondy
Copy link
Member Author

bbondy commented Sep 6, 2016

Actually it is just an l10n file update now, I did it on master but it didn't make this release unfortunately unless we have to respin rc2. I think it'll go out though.

@bbondy bbondy closed this as completed Sep 6, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Sep 6, 2016

It is the same on the 0.12.0.

The strings on the pop up dialog above have been translated since months, It seems that something else needs modifying too.
https://github.com/brave/browser-laptop/blame/master/app/extensions/brave/locales/ja-JP/passwords.properties#L13

@bbondy
Copy link
Member Author

bbondy commented Sep 7, 2016

you'll have to try on master, the strings didn't make it in on time for 0.12.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants