Copy version information tooltip is incorrect/not localized

[cndouglas]

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
On about:brave, the button to copy the version information has an incorrect tooltip. The tooltip currently says "Copy password to clipboard".

Expected behavior:
The tooltip should say something like "Copy version information to clipboard".

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All (found on macOS 10.12.x)

• Brave Version (revision SHA):
  Master (3c39b44)

• Steps to reproduce:

  1. Open a new Brave tab and navigate to about:brave
  2. Mouse over the copy to clipboard button.

• Screenshot if needed:
  

• Any related issues:
  None

[cndouglas]

browser-laptop/js/about/brave.js

Line 46 in d9824b3

<span className='fa fa-clipboard' title='Copy password to clipboard' onClick={this.onCopy} />

Also, it is not localized.

[cndouglas]

I can't get copyToClipboard to work. And copyToClipboard is listed in app/locale.js. Many other keys on that list do work, though. 😕

const locale = require('../l10n')
...
<span className='fa fa-clipboard' title={locale.translation('copyToClipboard')} onClick={this.onCopy} />

[luixxiul]

@liunkae nice find 👍

@bbondy do you think this is the same as #3946?

[bbondy]

yes I think so, I think we need to implement the l10n extensions API to get the localization here

[cndouglas]

I submitted PR #6392 for a temporary fix that changes the wording to "Copy to clipboard", until we get localization to work.

[bsclifton]

@liunkae I put a note about how you can fix the issue here:
https://github.com/brave/browser-laptop/pull/6392/files#r93702690

You can see js/about/history.js for examples (except that one uses it's own file, versus using app.properties)

[cndouglas]

PR: #6414

[luixxiul]

Test plan: #6414 (comment)