Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Social media buttons not rendered when Ad/Tracking is enabled #2985

Closed
srirambv opened this issue Aug 5, 2016 · 2 comments
Closed

Social media buttons not rendered when Ad/Tracking is enabled #2985

srirambv opened this issue Aug 5, 2016 · 2 comments
Assignees

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 5, 2016

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
Social media buttons not rendered when Ad/Tracking is enabled.

Expected behavior:
Should load all social media buttons when the page is loaded.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64, Windows 7 x32
  • Brave Version:
    0.11.2 Dev RC2
  • Steps to reproduce:
    1. Open https://thehackernews.com/
    2. The social media buttons under each article only shows Google+ and Facebook. Doesn't load the other three.
    3. Disable Ad/Tracking on the page, all social media images are loaded correctly.
    4. Popup window for ShareThis doesn't work since the script file and CSS files are blocked under Ad/Tracking
  • Screenshot if needed:
    Chrome Vs Brave
    image
  • Any related issues:
@lukemulks
Copy link
Collaborator

FYI - I'm rolling this issue into a parent initiative that I'm working on for social media network ads (w/in networks, and in embedded widgets and SDKs in the larger Web) - Tracking that initiative here for reference: #7678

@lukemulks
Copy link
Collaborator

Confirming that as of v0.14.0 (potentially earlier) social media buttons are showing up with shields enabled.

Screenshot captured below for reference.
brave-social-buttons-03312017-thehackernews

I'm going to close this issue, but if it resurfaces again we can reference this issue and open a new one.

@lukemulks lukemulks self-assigned this Mar 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants