-
Notifications
You must be signed in to change notification settings - Fork 973
Replace tracking social buttons with versions that don't track you #312
Comments
@PeterJensen This and the FOX News one is because it's blocking third-party cookies (also means Disqus (and other commenting systems), Social Buttons (Facebook, Twitter, G+), etc. also get blocked.) The only solution is to disable it for that site by right-clicking the tab. |
Yep, this is a known side-effect of blocking third party resources. Test site: https://sharemenot.cs.washington.edu/Test%20Installation.shtml Long term, we could replace those buttons with versions that don't track you, like Privacy Badger / ShareMeNot. |
Updated title. |
FYI - I'm rolling this issue into a parent initiative that I'm working on for social media network ads (w/in networks, and in embedded widgets and SDKs in the larger Web) - Tracking that initiative here for reference: #7678 Note: The focus for the initiative will be on stripping tracking wherever possible, while retaining functionality, but we may ultimately resort to button replacement if testing proves that is the only solution that will fully cover off. |
I've investigated this issue following the release of v0.14.0, and am no longer observing the issue as reported. Social networking buttons are displaying and clicking through as expected for both foxnews.com and tmz.com. I've also been checking social media button functionality with Brave Shields activated across several other domains, and am observing consistency with what has been observed for foxnews.com and tmz.com.
Screenshots of TMZ.com with the social media buttons displaying and functioning w/Shields up as expected. TMZ: Shields up, showing FB tracking blocked and buttons displaying: TMZ: Shields up, showing post-click share behavior for FB and Twitter share buttons: Foxnews.com HP, displaying the social buttons w/Shields up and tabs that load on click to share: Foxnews Politics section, displaying social buttons w/Shields up and share widget (post-click): Additionally, I dug into the Facebook ad and marketing API documentation, and applied the custom filters to block tracking, remarketing and audience tracking events that take place with the current FB embeds (outside of Facebook.com):
There are a couple of noteworthy items:
I'm going to close the issue at this point, but can open a new one and reference this issue if needed in the future. |
reopening this since we may want to implement sharemenot after all |
@lukemulks please migrate to the Brave core repos as needed 😄 |
Moving to the new codebase: brave/brave-browser#534 |
On TMZ there seems to be a missing FB like button. See attached screenshot:
The text was updated successfully, but these errors were encountered: