Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Titlebar on some Linux distros has a lot of wasted space #3126

Closed
KillianKemps opened this issue Aug 11, 2016 · 9 comments
Closed

Titlebar on some Linux distros has a lot of wasted space #3126

KillianKemps opened this issue Aug 11, 2016 · 9 comments
Labels
feature/titlebar fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. OS/unix-like/linux wontfix

Comments

@KillianKemps
Copy link

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Brave has a double titlebar on some Linux distributions (one from the desktop environment and one from Brave's Electron) which is useless and it wastes space. Some screenshots to illustrate:

Screenshot on Arch Linux with Gnome:
screenshot from 2016-08-10 09-38-01

Screenshot on elementaryOS (based on Ubuntu):
screenshot

Expected behavior:
As written for the similar issue for Windows #3036, it would be nice to only have Brave's titlebar without the one of the desktop environment.

@Sh1d0w
Copy link

Sh1d0w commented Aug 11, 2016

@KillianKemps I've quickly implemented it and rised a PR. I hope they like it. If so we will have this in the next release I hope.

Quick preview: http://webm.land/media/g4DR.webm

For more info #3036

bsclifton pushed a commit that referenced this issue Sep 7, 2016
bsclifton pushed a commit that referenced this issue Sep 8, 2016
bsclifton pushed a commit that referenced this issue Sep 9, 2016
bsclifton pushed a commit that referenced this issue Sep 9, 2016
@rscircus
Copy link

This one is hard to find.

Especially the hint to 👍 and prioritization...

@gri1n
Copy link

gri1n commented Mar 3, 2017

Shame that these changes made it into the Windows version but have been put on the backburner for Linux. The usual scenario.

@bsclifton
Copy link
Member

@gri1n one of the challenges is that Linux can have so many different looks and feels. For example, this can be ran with Ubuntu using Unity (which puts the menus at the top, not in the window). Also, users can customize the way the window looks (close button, maximize button, etc).

If we're OK making a generic and non-native looking UI, then this is very doable. I know @Sh1d0w would be very happy to get this in 😄

@gri1n @Sh1d0w @rscircus are there any similar apps that you can share screenshots for which don't render native widgets? (ex: custom rendered). For example, how does Chrome or Chromium look? I'm also curious about Firefox (which I believe does have a titlebar- not sure if it's optional)

@cndouglas
Copy link

We could:

  1. Add a preference called "Hide title bar" (disabled by default).
  2. If "Hide title bar" is enabled, remove the title bar and provide custom, non-native window controls.

@vmavromatis
Copy link

vmavromatis commented Mar 12, 2017

Add a preference called "Hide title bar" (disabled by default).

An option like that would be great. Confirming this for Ubuntu 16.04, quite a UI annoyance.

@Jacalz
Copy link
Contributor

Jacalz commented Dec 24, 2017

This would need client side decoration on the Linux version, related to #11767

Steam the game client uses non native buttons when you use it on Linux, they just use the same default that even is non native on windows. I would suggest just having the windows 10 decorations without having the close button light up red. That fits in nicely in to brave and should look good!

@WuerfelDev
Copy link

I'd love to see an implemention without using the current "Native Window". Seriously, this is the only thing that keeps me from switching the standard browser

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Jul 25, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 25, 2018
@bsclifton
Copy link
Member

This will finally be fixed when we move over to Brave Core 😄 Below, check out a screenshot from our last available build (Ubuntu using Gnome). Brave Core should be available in the next few months (hang tight!) 😄
screen shot 2018-07-25 at 12 05 23 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/titlebar fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. OS/unix-like/linux wontfix
Projects
None yet
Development

No branches or pull requests

10 participants