Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Non-script version of DuckDuckGo when blocking scripts is not loaded from location bar at first instance #3189

Closed
luixxiul opened this issue Aug 15, 2016 · 3 comments · Fixed by #3205
Closed

Non-script version of DuckDuckGo when blocking scripts is not loaded from location bar at first instance #3189

luixxiul opened this issue Aug 15, 2016 · 3 comments · Fixed by #3205
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.11.6dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 15, 2016 •
edited
Loading

Describe the issue you encountered: Non-script version of DuckDuckGo when blocking scripts is not loaded from location bar at first instance

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 64 bit
  • Brave Version: 0.11.5 RC1
  • Steps to reproduce:
    1. Move away AppData\Roaming\brave
    2. Start Brave
    3. Open settings
    4. Make "Block Scripts" on
    5. Select DuckDuckGo as the default search engine
    6. Open a new tab
    7. Search "brave" on that tab
    8. http://duckduckgo.com/?q=brave&t=brave (JS version) is opened
    9. Search "bravebrowser" in the same tab
    10. http://duckduckgo.com/html?q=bravebrowser&t=brave (non-JS version) is opened
    11. Search "brave" in the same tab
    12. http://duckduckgo.com/html?q=brave&t=brave (non-JS version) is opened
  • Screenshot if needed:
  • Any related issues: Manual tests for Win-x64 0.11.5 RC1 #3183 Minor:Brave uses incorrect search URL for DuckDuckGo with JS disabled #3118
@luixxiul
Copy link
Contributor Author

The same thing happens every time when you restart the browser.

This was referenced Aug 15, 2016
Closed
Closed
@luixxiul luixxiul changed the title Non-script version of DuckDuckGo during blocking scripts is sometimes not loaded Non-script version of DuckDuckGo when blocking scripts is not loaded from location bar at first instance Aug 15, 2016
@luixxiul
Copy link
Contributor Author

(Updated the title to explain the problem better)

@bbondy
Copy link
Member

bbondy commented Aug 15, 2016

cc @darkdh

@bbondy bbondy added this to the 0.11.6dev milestone Aug 15, 2016
@darkdh darkdh self-assigned this Aug 16, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Aug 16, 2016
@darkdh
Use noScript state per site instead of blocking scripts
fb9709c 
fix brave#3189

auditor: @bbondy
@darkdh darkdh mentioned this issue Aug 16, 2016
Merged
3 tasks
@luixxiul luixxiul mentioned this issue Aug 21, 2016
Closed
This was referenced Aug 21, 2016
Closed
Closed
Closed
This was referenced Aug 23, 2016
Closed
Closed
Closed
Closed
This was referenced Aug 24, 2016
Closed
Closed
Closed
Closed
This was referenced Aug 25, 2016
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@aekeus aekeus mentioned this issue Aug 31, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.11.6dev
Development

Successfully merging a pull request may close this issue.

Use noScript state per site instead of blocking scripts darkdh/browser-laptop
4 participants
@bbondy @alexwykoff @luixxiul @darkdh