Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Findbar should not hide on inter page navigation #323

Closed
bbondy opened this issue Jan 25, 2016 · 2 comments · Fixed by #2718
Closed

Findbar should not hide on inter page navigation #323

bbondy opened this issue Jan 25, 2016 · 2 comments · Fixed by #2718
Labels
bug/good-first-bug feature/findbar QA/checked
Milestone
0.11.2dev

Comments

@bbondy
Copy link
Member

bbondy commented Jan 25, 2016

Inside js/components/findbar.js

if (this.props.frame.get('location') !== prevProps.frame.get('location')) {
  this.props.onFindHide()

Yan writes:
"I don't think this should happen for inter-page navigation. probably need to listen for webview will-navigate or did-navigate"

I agree.
@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Jun 15, 2016
@cezaraugusto
Copy link
Contributor

@bbondy @diracdeltas is it still pending?

@diracdeltas
Copy link
Member

yup

@cezaraugusto cezaraugusto removed the needs-info Another team member needs information from the PR/issue opener. label Jun 15, 2016
david-gang added a commit to david-gang/browser-laptop that referenced this issue Jul 26, 2016
@david-gang
brave#323 - differentiate between external and internal navigation wh…
e4e9613 
…en hiding findbar.

The code was moved from findbar.js to frame.js, as it is more logic for the frame to decide who closes him
I wanted originally use will-navigate as it is better to close the find dialog beforehands, but for some reason the event did not fire when using   this.webview.addEventListener('will-navigate'
So i used did-navigate. This means that the search box will be closed after the user navigated.
@david-gang david-gang mentioned this issue Jul 26, 2016
Merged
bbondy added a commit that referenced this issue Jul 26, 2016
@bbondy
Merge pull request #2718 from david-gang/find-branch
26061bf 
#323 - differentiate between external and internal navigation when hiding findbar
@luixxiul luixxiul added this to the 0.11.2dev milestone Jul 26, 2016
@bbondy bbondy changed the title Change when findbar is hidden Findbar should not hide on inter page navigation Jul 29, 2016
This was referenced Jul 29, 2016
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 2, 2016
Closed
Closed
This was referenced Aug 3, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug feature/findbar QA/checked
Projects
None yet
Milestone
0.11.2dev
5 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @cezaraugusto