Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

If a site does not have a title, the bookmark should default to the url instead. #3344

Closed
alexwykoff opened this issue Aug 23, 2016 · 1 comment

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When attempting to bookmark http://alexwykoff.com/2/demo/ , the dialog would not allow me to continue because there was no title for the site.

Expected behavior:
While we should not allow users to save blank names for bookmarks, the default should exist that if a site has no title, the url is the default value given. 0.11.5 and prior have this default.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.11.6 pre-beta2
  • Steps to reproduce:
    1. Open the latest build
    2. Visit a site with no title, like http://alexwykoff.com/2/demo/
    3. Attempt to bookmark the page, observe the modal.
  • Screenshot if needed:
    add_bookmark_no_title
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Aug 27, 2016

I have no idea what's going on in that demo but it is making me non productive 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants