Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

If a site does not have a title, the bookmark should default to the url instead. #3442

Closed
alexwykoff opened this issue Aug 26, 2016 · 2 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When attempting to bookmark http://alexwykoff.com/2/demo/ the url did populate the appropriate entry in the modal, however the Save button was not enabled.

Expected behavior:
If the modal contains sufficient data, the Save button should be enabled.

@alexwykoff alexwykoff added this to the 0.11.6dev milestone Aug 26, 2016
@alexwykoff
Copy link
Contributor Author

I noticed the tests added to confirm the fix in #3344 . (fd60bac) I would suggest using .waitForEnabled instead of .waitForVisible.

@Sh1d0w Sh1d0w added the bug label Aug 26, 2016
@Sh1d0w Sh1d0w self-assigned this Aug 26, 2016
@Sh1d0w
Copy link

Sh1d0w commented Aug 26, 2016

The root cause of this is

fd60bac#diff-92301445f9beebf63f7a7ea1cc1a541fR106

The check if the bookmarkNameIsValid does not include the url check. This commit also introduced a new bug, now you can never have empty title input, it will be always be prepopulated with the URL if you try to delete everything with backspace and just type your custom title.

cc @bridiver

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants