Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

implement ledger recovery keys screen #3350

Closed
diracdeltas opened this issue Aug 23, 2016 · 13 comments · Fixed by #4196
Closed

implement ledger recovery keys screen #3350

diracdeltas opened this issue Aug 23, 2016 · 13 comments · Fixed by #4196

Comments

@diracdeltas
Copy link
Member

for advanced users who want to backup their ledger recovery keys

@bradleyrichter has mockups for this

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Aug 23, 2016

This functionality will now be accessed though a new Settings button at the top of the Payments UI:

image

The payments settings window shows 2 buttons at the bottom:
image

Clicking "Backup your wallet" opens this child window:
image

Clicking "Print keys" sends the keys text file to the printer dialog:

image

Clicking "Save recovery file" opens the save sheet/dialog with the file name preset.
image

(text file contents)

Brave Wallet Recovery Keys
Date created: 08/12/16

Recovery Key 1: e0c455d3-8b8a-40da-9358-2c38ce380b80
Recovery Key 2: 73de0bee-31f3-40e9-9a01-0f27958d925a

Note: These keys are not stored on Brave servers. These keys are your only method of recovering your Brave wallet. Save these keys in a safe place, separate from your brave browser.

When the "Recover your wallet" button is pressed, the Recover child window opens:
image

Clicking "Recover" starts the recovery process and provides status:
image

If the recovery is successful, a message is shown with the amount of the transfer:
image

If the recovery fails, the status messages changes to reflect the issue:
image

@diracdeltas diracdeltas added this to the 1.0.0 milestone Aug 27, 2016
@bradleyrichter bradleyrichter modified the milestones: 0.12.1dev, 1.0.0 Sep 4, 2016
@alexwykoff
Copy link
Contributor

Please make sure to document the recovery process as part of the steps for QA. Thanks!

@mrose17 mrose17 modified the milestones: 0.12.2dev, 0.12.1dev Sep 8, 2016
@ayumi
Copy link
Contributor

ayumi commented Sep 13, 2016

We talked about this and decided having plain text you can copy/paste(/take a screenshot of) would be suitable for the first iteration.

@diracdeltas
Copy link
Member Author

imo the 'Save' button should be replaced with a 'Show codes' button. as an advanced user, i don't have a printer or want to save the file to disk, i just want to see the code so i can copy/paste it somewhere safe.

@diracdeltas
Copy link
Member Author

@bradleyrichter why is this in the 'Advanced' panel instead of the Payments panel?

@bradleyrichter
Copy link
Contributor

@diracdeltas It was there because didn't have this new and improved Payments-specific settings dialog:

image

(includes "later" features so please ignore those for now)

@mrose17
Copy link
Member

mrose17 commented Sep 21, 2016

@jkup - i have the wallet recovery implemented in the server. i will provide an API call to ledger.js that you'll be able to invoke!

@jkup
Copy link
Contributor

jkup commented Sep 21, 2016

@bradleyrichter is all the "Advanced Settings.." has for now the view/print and recover buttons? Is the rest of the dialog empty?

Also in your first mockup there are both Backup and Recover buttons but in your second one there is only a View/Print button. Which are we going with?

@bradleyrichter
Copy link
Contributor

@mrose17 claims those settings are a slam-dunk to connect? So if easy, we can do them now.

The buttons are from different dialogs. Backup and Recover each have their own 2nd dialog.

mrose17 added a commit that referenced this issue Sep 22, 2016
in preparation to resolve
#3350 (by using
`client.recoverWallet`) and
#4058 (by using
`client.setTimeUntilReconcile`)
@mrose17 mrose17 reopened this Sep 23, 2016
@mrose17
Copy link
Member

mrose17 commented Sep 23, 2016

accidentally closed when a supporting ledger change was made!

@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 27, 2016
@jkup
Copy link
Contributor

jkup commented Sep 27, 2016

Bumping this because it's surely going to slip tonight.

@mrose17 @ayumi I have the front end work complete. Is the back end work finished? i.e can I get a user's ledger keys and is there an endpoint I can hit to recover them?

Assuming this work is done, can one of you help me with how to go about implementing it in the client? Thanks!

mrose17 added a commit that referenced this issue Sep 27, 2016
In support of #3350, use
the latest version of the ledger-client package that makes available a
client.getWalletPassphrase method

auditor: @ayumi
@bbondy
Copy link
Member

bbondy commented Sep 30, 2016

@jkup could you put up a WIP PR for this? Just want to see how close we are on it. Thanks!

@jkup
Copy link
Contributor

jkup commented Sep 30, 2016

Will do!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants