Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Existing bitcoin wallet address is not displayed #3440

Closed
luixxiul opened this issue Aug 26, 2016 · 8 comments
Closed

Existing bitcoin wallet address is not displayed #3440

luixxiul opened this issue Aug 26, 2016 · 8 comments
Assignees
@mrose17
Labels
feature/rewards OS/Windows QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.11.6dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:
On Windows, existing bitcoin wallet address is not displayed on the dialog which appears by clicking "Add Funds" on about:preferences#payments.

Expected behavior:
The bitcoin wallet address should be displayed.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 and 10
  • Brave Version: 0.11.6 Beta4
  • Steps to reproduce:
    1. Move your brave folder temporarily and start the browser
    2. Open Payments on about:preferences
    3. Enable the payment and click "create wallet"
    4. Click "add funds"
  • Screenshot if needed:
    clipboard01

The address is expected to be displayed around "copy this link".

  • Any related issues:

Setting a milestone.
@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 26, 2016
@alexwykoff
Copy link
Contributor

Confirmed this is isolated to Windows. OS X and Ubuntu displayed the wallet address appropriately.

@diracdeltas
Copy link
Member

diracdeltas commented Aug 26, 2016 •
edited
Loading

5e0b679 changes it so that an error message is shown if there is no address or payment URL available. that doesn't solve the underlying issue of why there is no paymentURL property on windows though.

@diracdeltas
Copy link
Member

@mrose17 any idea why paymentURL would be undefined only for windows? maybe intermittent failure related to ledger server?

@diracdeltas
Copy link
Member

@luixxiul could you open your session-store-1 file and copypaste the ledgerInfo value here? (or DM me on slack)

@luixxiul
Copy link
Contributor Author

It seems to be undefined: "ledgerInfo":{}.

@mrose17
Copy link
Member

mrose17 commented Aug 26, 2016

@luixxiul - please find the file ledger-state.json and DM it to @diracdeltas ... i think that @bsclifton knows where to find that on windows

@luixxiul
Copy link
Contributor Author

@mrose17 ok, sent it to @diracdeltas and you.

@mrose17 mrose17 self-assigned this Aug 26, 2016
mrose17 added a commit that referenced this issue Aug 27, 2016
@mrose17
@diracdeltas was right
4c53932 
it appears that the the concern about
https://github.com/brave/browser-laptop/blob/master/app/ledger.js#L735
explains #3440
@mrose17 mrose17 mentioned this issue Aug 27, 2016
Merged
@bbondy bbondy closed this as completed Aug 27, 2016
This was referenced Aug 27, 2016
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 29, 2016 •
edited
Loading

Confirmed it has been fixed on 0.11.6 Beta5 :-)

@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@aekeus aekeus mentioned this issue Aug 31, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

Labels
feature/rewards OS/Windows QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.11.6dev
Development

No branches or pull requests
5 participants
@mrose17 @diracdeltas @bbondy @alexwykoff @luixxiul