This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
updateLedgerInfo should run before client is assigned if previous state is present #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it appears that the the concern about https://github.com/brave/browser-laptop/blob/master/app/ledger.js#L735 explains #3440
|
@diracdeltas please audit, I'm going to merge in for beta5 though. |
|
++ |
This was referenced Aug 27, 2016
This was referenced Aug 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it appears the concern that @diracdeltas has regarding https://github.com/brave/browser-laptop/blob/master/app/ledger.js#L735 is proven, as it explains #3440
time for an extra-large helping of humble pie
auditor: @diracdeltas