Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

background color of find bar is not consistent #3526

Closed
luixxiul opened this issue Aug 29, 2016 · 6 comments
Closed

background color of find bar is not consistent #3526

luixxiul opened this issue Aug 29, 2016 · 6 comments
Labels
design A design change, especially one which needs input from the design team. feature/findbar wontfix

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:
clipboard01
clipboard02

Expected behavior: I expect the background color of the find bar to be consistent. For now it is so contrast that it looks to me like a bug.

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Aug 29, 2016
@bbondy
Copy link
Member

bbondy commented Aug 29, 2016

it is supposed to be matching the themeColor per design.
/cc @bradleyrichter

note that there should be black vs white text though depending on the contrast, please post if that's not the case.

Marking this as wontfix though.

@bbondy bbondy added the wontfix label Aug 29, 2016
@bbondy bbondy closed this as completed Aug 29, 2016
@bradleyrichter
Copy link
Contributor

it needs a bit more work to look like this:

image

@bradleyrichter
Copy link
Contributor

also, your white BG screen shot may be a bug. That shouldn't happen as Brian explained. The text and element colors should match the tab text color.

cc @jkup

@jkup
Copy link
Contributor

jkup commented Aug 29, 2016

That looks right to me in the sense that if the tab is white, the findbar should be white, right?

@luixxiul
Copy link
Contributor Author

With border: 2px solid #ddd for example,
clipboard01

the input field seems to me much noticeable here.

@bsclifton
Copy link
Member

Created #5319 to track the theme colored input box

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/findbar wontfix
Projects
None yet
Development

No branches or pull requests

5 participants