Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Findbar has style issues (alignment) #5317

Closed
bsclifton opened this issue Nov 1, 2016 · 3 comments · Fixed by #5318
Closed

Findbar has style issues (alignment) #5317

bsclifton opened this issue Nov 1, 2016 · 3 comments · Fixed by #5318
Labels
bug feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 1, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Findbar has a style issue (see screenshot)

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version:
    0.12.7

  • Steps to reproduce:

    1. Launch Brave and open a page which sets a color for the tab
    2. Open the findbar
    3. Be sad because it looks like the screenshot ☹️ (notice the alignment problems)

  • Screenshot if needed:
    image

It should look like this:
image

  • Any related issues:
@bsclifton bsclifton added the bug label Nov 1, 2016
@bsclifton bsclifton added this to the 0.12.8dev milestone Nov 1, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Nov 1, 2016

I think this is duping to #3526. Though it was labelled wontfix, the styling may seem to be a bug.

@luixxiul luixxiul added the duplicate Issue has already been reported label Nov 1, 2016
@bsclifton bsclifton mentioned this issue Nov 1, 2016
Merged
4 tasks
@bsclifton bsclifton removed the duplicate Issue has already been reported label Nov 1, 2016
@bsclifton
Copy link
Member Author

@luixxiul this one is actually fixing the way the tabs and findbar align 😄 I will go through the ticket you posted and create a new issue for the coloring of the actual input box

@bsclifton bsclifton changed the title Findbar style has an issue Findbar has style issues (alignment) Nov 1, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Nov 1, 2016

@bsclifton ah I see, thanks!

bbondy pushed a commit that referenced this issue Nov 2, 2016
@bradleyrichter @bbondy
Fixed shadowing, colors, alignments on mac
5f7193b 
Also, style fix for find bar

Fixes #5317

Auditors: @bbondy
This was referenced Nov 2, 2016
Closed
Closed
Closed
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Style updates per Brad (Findbar + fixed shadowing, colors, alignments on mac)
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv