Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add currency symbols where appropriate #3533

Closed
jkup opened this issue Aug 29, 2016 · 6 comments
Closed

Add currency symbols where appropriate #3533

jkup opened this issue Aug 29, 2016 · 6 comments

Comments

@jkup
Copy link
Contributor

jkup commented Aug 29, 2016

Using a library like https://www.npmjs.com/package/currency-symbol-map it would be nice to add currency symbols on the ledger settings pages for the appropriate currency type.

It looks like "currency" is stored in state as a string (https://github.com/brave/browser-laptop/blob/master/docs/state.md#L403), so we should just be able to pipe it through a library like the one above and then prepend it to the currency number.

@luixxiul
Copy link
Contributor

Test plan: #6249 (comment)

@bradleyrichter
Copy link
Contributor

This needs to be changed to use ISO 4217 3-letter codes instead of symbols.

@bsclifton bsclifton assigned bsclifton and unassigned jkup Jan 18, 2017
@bsclifton
Copy link
Member

I'll get this squared away

@bsclifton
Copy link
Member

The fix for this issue was reverted with #6720. Removing milestone from this issue + original PR.

cc: @luixxiul in case you needed to remove the release notes for this

@mrose17
Copy link
Member

mrose17 commented Jan 19, 2017

let's declare this done!

@luixxiul
Copy link
Contributor

I added QA/no qa needed release-notes/exclude labels

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants