-
Notifications
You must be signed in to change notification settings - Fork 970
Add currency symbols where appropriate #6249
Conversation
How is @jkup can you screenshot the places where currency is updated? I'm also curious how the formatting looks for other currency |
@bsclifton yep it's based on the IP. I added a screenshot of what this looks like for USD but I'm a little hesitant to ship this ticket because after talking with @mrose17 it turns out faking the currency is difficult to do. I suppose my only real worry is that we support some currency that doesn't exist in this package's currency map (https://github.com/bengourley/currency-symbol-map/blob/master/map.js) so it will default to USD instead. Thoughts? |
the list is fairly comprehensive, so i'm no worried about it. we do not have plans to turn on additional currencies right now, so i don't think this is a priority. i would do the PR and then mark the issue closed. |
++ lgtm |
Thanks for the update! Looks good 😄 |
Note:
|
@luixxiul yep this is how adding npm packages works |
@cezaraugusto This PR is useful but needs to be corrected ASAP to show the ISO 4217 currency code (3 letters) instead of the symbol. |
This was reverted; removing milestone |
git rebase -i
to squash commits (if needed).Fix #3533
Auditors @bsclifton @cezaraugusto
Test Plan: