Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger visit timer keeps running when Brave is in the background #3650

Closed
bridiver opened this issue Sep 1, 2016 · 0 comments
Closed

Ledger visit timer keeps running when Brave is in the background #3650

bridiver opened this issue Sep 1, 2016 · 0 comments
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified
Milestone
0.12.0dev

Comments

@bridiver
Copy link
Collaborator

bridiver commented Sep 1, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When Brave is not the foreground app, the timer will continue to run for the last active tab. It will also continue to run if Brave is the foreground app and the computer is either idle for a long time or locked

Expected behavior:
The timer should stop if Brave is not the foreground app or if the computer has been idle/locked

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    0.11.6
  • Steps to reproduce:
    1. Open forbes.com
    2. Click on another app, lock the computer or leave it idle for at least 15 minutes
    3. Wait at least 10 seconds (Or 15 min for idle)
    4. Check the ledger site list

cc @BrendanEich
@bridiver bridiver mentioned this issue Sep 1, 2016
Merged
@bbondy bbondy closed this as completed in 92722fb Sep 4, 2016
@bbondy bbondy added this to the 0.12.0dev milestone Sep 4, 2016
bbondy added a commit that referenced this issue Sep 4, 2016
@bbondy
Tweak changelog for 0.12.0
63ea3b2 
Added periods to each line for consistency.
Removed separator thing which was not important and was stating the opposite
of what it actually was I think.

Added these:
- Fixed problems with hangouts on inbox.google.com and mail.google.com
   when shields are up.
   ([#3704](https://github.com/brave/browser-laptop/issues/3704))([#3704](https://github.com/brave/browser-laptop/issues/3704))
- Fixed time spent on page calculation for ledger when Brave is in
  the background.
  ([#3650](#3650))

Auditors: @alexwykoff

Test Plan: n/a
@alexwykoff alexwykoff mentioned this issue Sep 5, 2016
Closed
30 tasks
This was referenced Sep 5, 2016
Closed
Closed
Closed
Closed
@bbondy bbondy mentioned this issue Jan 2, 2017
Closed
bbondy added a commit that referenced this issue Jan 2, 2017
@bbondy
Re-enable idle timer for ledger timer visits
432d060 
It was added here originally:
#3650

But then removed here when things were still in progress:
dbc0796

It works fine though, so re-enabling it.

Fix #6497

Auditors: @bridiver
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified
Projects
None yet
Milestone
0.12.0dev
Development

No branches or pull requests
6 participants
@bridiver @bbondy @alexwykoff @luixxiul @bsclifton @srirambv