Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Split components out of preferences.js #3717

Closed
jkup opened this issue Sep 5, 2016 · 2 comments
Closed

Split components out of preferences.js #3717

jkup opened this issue Sep 5, 2016 · 2 comments

Comments

@jkup
Copy link
Contributor

jkup commented Sep 5, 2016

This is just a nice to have, but there are like 20 components inside of the preferences.js file. It would be nice to split them out into separate files for testing / readability / making them easier to find.

@luixxiul
Copy link
Contributor

Also I’m wondering if it would improve readability of preferences.less by separating it to files in a folder like this:

less/about/preferences/preferences.less
less/about/preferences/general.less
less/about/preferences/search.less

The common rules should be set in preferences.less and the other files should be imported to it.

@jkup
Copy link
Contributor Author

jkup commented Nov 23, 2016

@luixxiul this is definitely a good call! My only worry is spending time on LESS when we are moving to Aphrodite. Maybe it would be best to split the .js files up and then one by one move the applicable preferences.less stylings into Aphrodite objects?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants