Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Split PaymentsTab into its own component #6528

Closed
jkup opened this issue Jan 5, 2017 · 3 comments · Fixed by #6529
Closed

Split PaymentsTab into its own component #6528

jkup opened this issue Jan 5, 2017 · 3 comments · Fixed by #6529
Labels
automated-tests QA/no-qa-needed refactoring release-notes/exclude tests
Milestone
0.13.2

Comments

@jkup
Copy link
Contributor

jkup commented Jan 5, 2017

This relates to both #3717 and #5887. In order to unit test the changes mentioned in #5887 it's easiest to split it out into its own component.
@jkup jkup added this to the 0.13.1 milestone Jan 5, 2017
@jkup jkup self-assigned this Jan 5, 2017
@jkup jkup mentioned this issue Jan 5, 2017
Merged
4 tasks
@luixxiul
Copy link
Contributor

Several duplicate declaration errors start appearing

@bsclifton
Copy link
Member

@luixxiul my bad- reverted with 7031a2b

@luixxiul luixxiul reopened this Jan 27, 2017
@bbondy bbondy modified the milestones: 0.13.2, 0.13.1 Jan 28, 2017
@bsclifton
Copy link
Member

This was fixed after we resolved manual merge issues

See
revert of many 0.13.1 branch changes - 4de7cf4
proper merge of all 0.13.1 changes - af368d3
fix for this issue specifically - ad2cd84

@bsclifton bsclifton modified the milestones: 0.13.1, 0.13.2 Jan 30, 2017
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-tests QA/no-qa-needed refactoring release-notes/exclude tests
Projects
None yet
Milestone
0.13.2
Development

Successfully merging a pull request may close this issue.

Split PaymentsTab into its own component brave/browser-laptop
4 participants
@jkup @bbondy @luixxiul @bsclifton