Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave doesn't remember last position and size if you set it to start with homepage #3754

Closed
Sh1d0w opened this issue Sep 6, 2016 · 13 comments · Fixed by #5102
Closed

Brave doesn't remember last position and size if you set it to start with homepage #3754

Sh1d0w opened this issue Sep 6, 2016 · 13 comments · Fixed by #5102

Comments

@Sh1d0w
Copy link

Sh1d0w commented Sep 6, 2016

Test plan

  1. Open preferences > general
  2. Set Brave starts with to My homepage
  3. Move the window to a unique position and resize it also
  4. Close Brave and reopen
  5. Window should have retained its position

Original issue description

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
When closed Brave does not retain last window position and size as it should be when re-launched.

This happens only if in Settings -> General you set the value for Brave starts with to My homepage. If you select Session and tabs from last time it correctly remembers the position and the size of the window.

Expected behavior:
Brave should remember the last window position and size regardless what I choose Brave to load initially.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Linux, Fedora 24
  • Brave Version:
    0.12.0dev downloaded from here
  • Steps to reproduce:
    1. In settings -> general set Brave starts with to My homepage
    2. https://s11.postimg.org/y5tetpkkj/window_bug.gif
  • Screenshot if needed:
  • Any related issues:
@Sh1d0w Sh1d0w added the bug label Sep 6, 2016
@Sh1d0w Sh1d0w changed the title Brave always starts maximized, doesn't remember last position and size Brave doesn't remember last position and size if you set it to start with homepage Sep 6, 2016
@bsclifton
Copy link
Member

bsclifton commented Oct 4, 2016

Good call, @Sh1d0w! I just manually tested and confirmed #4482 does seem to fix this issue

@Sh1d0w
Copy link
Author

Sh1d0w commented Oct 8, 2016

Unfortunately after I installed 0.12.4 it does not seem to fix this issue. The problem still exists if you follow the STR in the issue above.

Set Brave starts with to My home page and observe that resizing and closing the window, always launches in fullsize when you relaunch the browser. Brave should remember its last position and size regardless of the option set for Brave starts with

@bbondy
Copy link
Member

bbondy commented Oct 10, 2016

if you select my home page then no last window state is saved. I guess we need to use the last window size / pos in that case for the next new Window.

@bsclifton bsclifton removed this from the 0.12.9dev milestone Nov 8, 2016
@bsclifton
Copy link
Member

Removing milestone for the time being

@bsclifton bsclifton removed this from the 0.12.10 release milestone Nov 17, 2016
@srirambv
Copy link
Collaborator

srirambv commented Dec 1, 2016

Two more reports from support on not remembering window position
https://linkbubble.zendesk.com/agent/tickets/7082
https://linkbubble.zendesk.com/agent/tickets/7079

@srirambv
Copy link
Collaborator

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton Aug 14, 2017
@NejcZdovc NejcZdovc added this to the 0.20.x (Developer Channel) milestone Aug 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 14, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 17, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.