Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave crashes when tabs are pinned(Intermittent issues) #3760

Closed
srirambv opened this issue Sep 6, 2016 · 10 comments · Fixed by #10531
Closed

Brave crashes when tabs are pinned(Intermittent issues) #3760

srirambv opened this issue Sep 6, 2016 · 10 comments · Fixed by #10531
Labels
crash feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 6, 2016 •
edited by luixxiul
Loading

Test plan

#10531 (comment)

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Brave crashes when tabs are pinned on a clean install build

Expected behavior:
Should not crash when tabs are pinned

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.0 RC2 (Clean install)
  • Steps to reproduce:
    1. Perform a clean install
    2. Open 5-6 tabs and start pinning each of them
    3. After pinning the first two-three tabs the next tab when pinned browser crashes
  • Screenshot if needed:
  • Any related issues:
@Sh1d0w Sh1d0w added the crash label Sep 6, 2016
@bbondy
Copy link
Member

bbondy commented Sep 6, 2016

Triage related question, is this reproducible with past versions as well?

@bbondy bbondy added this to the 0.12.1dev milestone Sep 6, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Sep 6, 2016

No. Just happened on the RC2 build. Reinstalled and checked but doesn't happen

@bbondy
Copy link
Member

bbondy commented Sep 6, 2016

but if you try again with RC2 do you not reproduce as well? Is it more likely to happen in current build vs old builds?

@srirambv
Copy link
Collaborator Author

srirambv commented Sep 6, 2016

Yes tried again with RC2. In fact installed RC1 and then ran RC2 build, then uninstalled completely and did a clean install of RC2 but no luck in reproducing the issue.

@bbondy bbondy modified the milestones: 0.12.2dev, 0.12.1dev Sep 9, 2016
@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 17, 2016
@srirambv
Copy link
Collaborator Author

Able to reproduce consistently on 0.12.2 RC3 build by creating new session folder each time. Number of tabs varies each time the crash happens

crash

crash1

@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@jonathansampson
Copy link
Collaborator

This issue was recently encountered by a user on Twitter:

@brave @BrendanEich Started using Brave today and when I pin a tab the browser closes. It happened 2 times. I'm on Ubuntu 16 (https://twitter.com/ribeiroigao/status/782902088594522114)

This was referenced Oct 4, 2016
Closed
Closed
Closed
Closed
@diracdeltas diracdeltas modified the milestones: 0.12.5dev, 0.12.4dev Oct 4, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.4dev Oct 5, 2016
This was referenced Oct 5, 2016
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Oct 6, 2016

Able to reproduce on 0.12.4 Preview 2 as well. After pinning 5 tabs browser crashed

@alexwykoff alexwykoff mentioned this issue Oct 6, 2016
Closed
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 10, 2016
@bbondy bbondy removed this from the 0.12.6dev milestone Oct 18, 2016
@srirambv
Copy link
Collaborator Author

Browser crashes on each tab that is pinned on 0.13.0 preview 9. Recording from installation
http://sendvid.com/z4i8fk8z

cc: @bbondy

@luixxiul luixxiul added this to the 0.13.1 milestone Jan 19, 2017
@luixxiul
Copy link
Contributor

Setting the next milestone in case it's serious issue

@jonathansampson jonathansampson mentioned this issue Feb 1, 2017
Closed
@bbondy
Copy link
Member

bbondy commented Feb 1, 2017

Can we mark this as a dupe of:
#6968
?

@bbondy bbondy removed this from the 0.13.2 milestone Feb 2, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
fa9b09b 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
6248c7c 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@petemill petemill mentioned this issue Aug 16, 2017
Merged
8 tasks
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 26, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f912e34 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a9443d5 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f9a6772 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 28, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a8e12ab 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bsclifton bsclifton added this to the 0.21.x (Nightly Channel) milestone Aug 28, 2017
bsclifton pushed a commit to petemill/browser-laptop that referenced this issue Aug 29, 2017
@petemill @bsclifton
Stop losing pinned tabs in a window when adding or removing another p…
01008da 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
crash feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
8 participants
@diracdeltas @jonathansampson @bbondy @luixxiul @bsclifton @Sh1d0w @srirambv @LaurenWags