Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Save As/file selection dialog appears twice when offline #3784

Closed
gulkily opened this issue Sep 7, 2016 · 3 comments · Fixed by #11906
Closed

Save As/file selection dialog appears twice when offline #3784

gulkily opened this issue Sep 7, 2016 · 3 comments · Fixed by #11906

Comments

@gulkily
Copy link

gulkily commented Sep 7, 2016

Test plan

#11906 (comment)


Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When offline, using the Save As command results in the file selection dialog appearing twice

Expected behavior:
Dialog should only appear once

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.12.0
  • Steps to reproduce:
    1. Load a page
    2. Disconnect from network
    3. File | Save As
    4. Choose a file name and press Save

Expected: Page saved, no further activity

Actual: Page is not saved (#3783) and the Save As/file-selection dialog appears again

  • Screenshot if needed:
  • Any related issues:
@charbelrami
Copy link
Contributor

charbelrami commented Sep 7, 2016

Reproduced on Win 10 64-bit.

'Save As' opens the folder where the latest download was saved, e.g. Desktop.
If you press Save, it closes that folder and opens the 'Downloads' folder.

@charbelrami charbelrami added the bug label Sep 7, 2016
@bsclifton bsclifton changed the title Save As/file selection dialog appears when offline Save As/file selection dialog appears twice when offline Nov 11, 2017
@darkdh darkdh self-assigned this Nov 11, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@darkdh darkdh modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Jan 27, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@kjozwiak
Copy link
Member

kjozwiak commented Mar 22, 2018

Verified that the above issue has been fixed on macOS 10.13.3 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Also went through the case mentioned in #3784 (comment)

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.