Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Balance of bitcoin can show a scary 0 value when no connection #3785

Closed
bbondy opened this issue Sep 7, 2016 · 3 comments
Closed

Balance of bitcoin can show a scary 0 value when no connection #3785

bbondy opened this issue Sep 7, 2016 · 3 comments
Assignees
@ayumi
Labels
duplicate Issue has already been reported feature/rewards QA/checked-Linux QA/checked-Win64
Milestone
0.12.1dev

Comments

@bbondy
Copy link
Member

bbondy commented Sep 7, 2016

  1. Close browser
  2. Turn internet off
  3. Open browser
  4. Open prefs -> Payments

Actual result: Shows balance of 0
Expected result: Shows some kind of an error that the data could not be retrieved

Likely alternate way to reproduce, turn off remote service.
@bbondy bbondy added this to the 0.12.1dev milestone Sep 7, 2016
@da2x
Copy link
Contributor

da2x commented Sep 7, 2016 •
edited
Loading

Duplicate of #3778.

@luixxiul luixxiul added the duplicate Issue has already been reported label Sep 7, 2016
@bbondy
Copy link
Member Author

bbondy commented Sep 7, 2016

Thanks, closing as a dupe.

@bbondy bbondy closed this as completed Sep 7, 2016
@bbondy bbondy removed this from the 0.12.1dev milestone Sep 7, 2016
@bbondy
Copy link
Member Author

bbondy commented Sep 7, 2016

It might have a diff fix, will re-open for now.

@bbondy bbondy reopened this Sep 7, 2016
@ayumi ayumi self-assigned this Sep 7, 2016
ayumi added a commit that referenced this issue Sep 7, 2016
@ayumi
Show "loading" when payments balance is loading
09d03e5 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
ayumi added a commit that referenced this issue Sep 7, 2016
@ayumi
Show "loading" when payments balance is loading
40b5072 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
ayumi added a commit that referenced this issue Sep 8, 2016
@ayumi
Show "loading" when payments balance is loading
070aa76 
Fix #3778
Fix #3785 or at least a gentle fallback

Auditors: @diracdeltas @bbondy

Test Plan:

Offline case:
1. Disable internet
2. Re/open Brave
3. Open Preferences -> Payments
4. Observe that account balance is "loading..." and not 0

Online case:
1. Open Brave
2. Open Preferences -> Payments
3. Observe account balance is accurate
@ayumi ayumi mentioned this issue Sep 8, 2016
Merged
4 tasks
ayumi added a commit that referenced this issue Sep 8, 2016
@ayumi
Improve UX of unavailable ledger balance
3e1f025 
Fix #3778
Fix #3785 or at least a gentle fallback
@ayumi ayumi closed this as completed in fffa903 Sep 8, 2016
@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 8, 2016
This was referenced Sep 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
duplicate Issue has already been reported feature/rewards QA/checked-Linux QA/checked-Win64
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
5 participants
@ayumi @bbondy @da2x @alexwykoff @luixxiul