-
Notifications
You must be signed in to change notification settings - Fork 973
Improve UX of unavailable ledger balance #3805
Conversation
8278f41
to
3e1f025
Compare
|
||
// if the last updateLedgerInfo happened concurrently with an error, this | ||
// saves it for UI or debugging | ||
error: null // { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @diracdeltas is fond of saying: don't forget to update docs/state.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, that is a good idea
@ayumi - have you been able to reproduce either of the issues? i never have. my theory has been that on a mac, sometimes i see the payments panel show the 'Welcome to Brave Payments' page and then flip into the actual page a few 100ms later. on linux, i suspect that something similar may be going on. what's your thinking? thanks! |
3e1f025
to
fffa903
Compare
@mrose17 I can repro #3785 and #3778 at 5b10525 on Mac OS X. I've repro'd by disabling wifi and by specifically blocking Brave using Little Snitch. This PR fixes it for me. |
@ayumi - excellent! please merge the PR into master! |
git rebase -i
to squash commits (if needed).Fix #3778 #3785
Adds
ledgerInfo.error
for debugging and UI.Auditors: @mrose17 @bbondy
Test Plan:
Offline case:
Online case:
Offline case / Expected result: