Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

History list shows unnecessary duplicates for same-page actions (like google maps) #3848

Closed
bradleyrichter opened this issue Sep 9, 2016 · 12 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Sep 9, 2016

Test plan

  1. Visit Google maps (maps.google.com)
  2. Move around, zoom in, etc
  3. Look at history (Cmd + Y / Ctrl + Y)
  4. There shouldn't be a ton of duplicate entries (see below picture)

Original issue description

image

@luixxiul
Copy link
Contributor

luixxiul commented Sep 9, 2016

I noticed it on Gmail too.

@bbondy
Copy link
Member

bbondy commented Sep 10, 2016

different in-page navigation I guess?

@bbondy bbondy modified the milestones: 0.12.2dev, 0.12.1dev Sep 10, 2016
@bsclifton
Copy link
Member

I bet any query string params or anchor tags are counting as distinct entries- looking at what Chrome and Firefox do would be a good idea for next steps

@bbondy
Copy link
Member

bbondy commented Sep 11, 2016

in-page navigation shouldn't add an entry I think is the main thing. It's a different event in frame.js

@bbondy bbondy modified the milestones: 0.12.3dev, 0.12.2dev Sep 20, 2016
@bsclifton bsclifton modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

I think we're calling addSite in frame.js for in-page navigation
Would still like this for 0.12.4.

@bsclifton
Copy link
Member

Gonna have to dig a little deeper on this one... you had added this here:
e44d45e

To avoid a regression, I'll need to test the icon loading scenarios

@bsclifton
Copy link
Member

@bbondy can we kick this to 0.12.5?

@bbondy
Copy link
Member

bbondy commented Oct 5, 2016

sure

@bsclifton bsclifton removed this from the Backlog milestone May 3, 2017
@bsclifton bsclifton self-assigned this May 3, 2017
@bsclifton bsclifton added the perf label May 4, 2017
@bsclifton bsclifton modified the milestones: 0.15.4, 0.15.3 May 4, 2017
@ayumi ayumi self-assigned this May 4, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 27, 2017
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jul 18, 2017
@bsclifton bsclifton assigned bbondy and unassigned ayumi and bsclifton Jul 18, 2017
@bsclifton bsclifton modified the milestones: 0.17.17 (Release Channel), 0.19.x (Beta Channel) Jul 18, 2017
@bsclifton bsclifton added release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Jul 18, 2017
@bsclifton
Copy link
Member

Per @bbondy, this should be fixed with #10005. Let's retest it 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.