Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Optimize getTopSites #10005

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Optimize getTopSites #10005

merged 2 commits into from
Jul 17, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 16, 2017

Fix #10004

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  • Re-test top sites completely (new tab tiles)
    • For example clear private data, make sure it clears the top sites back to default
    • There will be a slight delay (intentional) on re-calculating top sites, within 5 seconds after page load.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.18.x (Release Channel) milestone Jul 16, 2017
@bbondy
Copy link
Member Author

bbondy commented Jul 17, 2017

ready for review

@bbondy bbondy changed the title WIP: Optimize top sites Optimize top sites Jul 17, 2017
@bbondy
Copy link
Member Author

bbondy commented Jul 17, 2017

screen shot 2017-07-16 at 10 02 50 pm

There's the end result under the name debounce, the test was run over 20 page views. Before it was over 7% of the time.

@bbondy bbondy modified the milestones: 0.18.x (Release Channel), 0.17.17 (Release Channel) Jul 17, 2017
@bbondy bbondy changed the title Optimize top sites Optimize getTopSites Jul 17, 2017
@bbondy bbondy self-assigned this Jul 17, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look and work great 😄 Awesome find 👍

BTW: @bbondy any manual QA needed? If so please add steps; if not, please add QA/no-qa-required tag. Thanks 😄

@bsclifton bsclifton merged commit 901145e into master Jul 17, 2017
@bsclifton bsclifton deleted the top-sites branch July 17, 2017 19:27
bsclifton added a commit that referenced this pull request Jul 17, 2017
bbondy pushed a commit that referenced this pull request Jul 17, 2017
bbondy pushed a commit that referenced this pull request Jul 17, 2017
@bbondy bbondy mentioned this pull request Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants