Regression : Spell check is missing

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When mistyping words, Brave usually underlines the word and provides alternative spellings in the context menu.

Expected behavior:
The misspelled word should be highlighted and alternative spellings should be shown in the context menu.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Discovered on Linux, confirmed on OS X
• Brave Version:
  0.12.1 Preview1 & Preview 3
• Steps to reproduce:
  1. Visit a site with a text input field (ex: https://wordcounter.net/)
  2. Misspell a word 'fead' instead of 'feed' or the like.
• Screenshot if needed:
  
  
• Any related issues: Spell check does not work on Windows 10 with JP #2602

[bridiver]

definitely something strange going on. Doesn't seem to work at all on the page you provided, but works on http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea for some misspellings. Could be a locale/dictionary issue

[bbondy]

There's an HTML attribute that disables it that we respect purposely. Does Chrome show spell check there?

[bbondy]

and did it used to work (I'm assuming so because you used the word Regression)

[bridiver]

yea, spellcheck works on chrome for that page

[luixxiul]

Cannot confirm on Win10 JP due to #2602

[bridiver]

is #2602 just a missing JP dictionary? Can you check for English? I don't have a win10 vm running at the moment, but I can't start one if needed

[luixxiul]

I changed the language setting of Brave into English and tried again. Still not working.

[bridiver]

I'm not able to replicate a problem with spellcheck in general, the only problem I see is that the dictionary seems to contain some words that aren't really words, but the behavior is nearly identical on Chrome and Safari. Typing a fdsafds or aas triggers spellcheck for me. fead doesn't trigger spellcheck on any browser on mac

[bridiver]

[bridiver]

there was an issue getting the settings into the release build. @bbondy should be spinning new builds soon