QR Code Popup from Add funds dialog scrolls independently from its parent

[bradleyrichter]

It is one of the cutest bugs I have ever seen. But a bug, none the less.

(found on a Dell XPS with touchpad scrolling)

Brave 0.12.1 release version

[luixxiul]

Is this intended?

[bbondy]

Assuming the current behavior is not horrible I'm moving it to 0.12.3, let me know if anyone disagrees.

[luixxiul]

On a small window with a vertical scroll bar it still happens.

wontfix?

[bradleyrichter]

needs more fixing

@jkup Any ideas? If it's only at this small size, we can push this out to 0.12.4.

[aekeus]

Independent scroll on macOS

[jkup]

I think I'm just not understanding what the desired behavior is here. Is the bug the fact that the background of the page like monthly budget, balance and statements is scrolling when you try to scroll the modal?

Because the modal itself should scroll right? So you can get to the bottom or top of the content?

[srirambv]

@jkup When the window size is reduced there is horizontal shift in the position of the QA Code popup after that it starts moving independently when the main window has vertical scroll bars.

[bradleyrichter]

@jkup

I think the best approach may be to restrict scrolling to the main parent window and child objects are relative to each parent.

If the child doesn't fit, then the parent scrolls and the child moved with it. (As if the entire viewable area was a big screenshot.)

What we have now feels more like nested iframes?

On Sep 28, 2016, at 10:11 PM, Jon Kuperman notifications@github.com wrote:

I think I'm just not understanding what the desired behavior is here. Is the bug the fact that the background of the page like monthly budget, balance and statements is scrolling when you try to scroll the modal?

Because the modal itself should scroll right? So you can get to the bottom or top of the content?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[jkup]

@bradleyrichter ok I'll try that! Modals on top of modals present a lot of challenges :)

[bradleyrichter]

We may be able to use modal replacement instead of opening another. Other browsers have the same issue. I'll try to find an example.

On Sep 29, 2016, at 11:03 PM, Jon Kuperman notifications@github.com wrote:

@bradleyrichter ok I'll try that! Modals on top of modals present a lot of challenges :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[jkup]

@bradleyrichter ok I'm happy to go either way, also @srirambv I'm not seeing that horizontal shift on my mac, what OS are you on there?

[srirambv]

@jkup Its on a Windows 10 machine