Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

QR Code Popup from Add funds dialog scrolls independently #4071

Merged
merged 1 commit into from
Sep 17, 2016
Merged

QR Code Popup from Add funds dialog scrolls independently #4071

merged 1 commit into from
Sep 17, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 17, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4043

Test Plan:

Auditor: @bradleyrichter

Make sure the qrcode doesn't scroll unnecessarily when opened.

@jkup jkup added the design A design change, especially one which needs input from the design team. label Sep 17, 2016
@jkup jkup added this to the 0.12.2dev milestone Sep 17, 2016
@bbondy
Copy link
Member

bbondy commented Sep 17, 2016

++

@bbondy bbondy merged commit 6f89aab into master Sep 17, 2016
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
@bbondy bbondy deleted the qr-code-scrolling branch September 23, 2016 00:01
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging this pull request may close these issues.
6 participants
@jkup @bbondy @aekeus @alexwykoff @luixxiul @srirambv