Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

On browser startup, Preferences > Payments briefly shows off/disabled view #4066

Closed
ayumi opened this issue Sep 16, 2016 · 4 comments
Closed

On browser startup, Preferences > Payments briefly shows off/disabled view #4066

ayumi opened this issue Sep 16, 2016 · 4 comments
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@ayumi
Copy link
Contributor

ayumi commented Sep 16, 2016 •
edited by luixxiul
Loading

Test plan

  1. Enable Payments
  2. Open 10 tabs of stuff
  3. Open Preferences > Payments
  4. Restart browser
  5. Make sure that browser reloads Payments page in the on state

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:

When the last active tab was Preferences > Payments and you restart the browser, the Payments page briefly in the Payments off state even with Payments on.

Mentioned in #3781 (comment)

Expected behavior:

Payments page should always accurately reflect Payments on/off status.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Mac OS
  • Brave Version:
    0.12.1
  • Steps to reproduce:
    1. Enable Payments
    2. Open 10 tabs of stuff
    3. Open Preferences > Payments
    4. Restart browser
    5. Browser reloads Payments page in the off state
@ayumi ayumi mentioned this issue Sep 16, 2016
Closed
@mrose17 mrose17 added this to the 0.12.3dev milestone Sep 16, 2016
@diracdeltas
Copy link
Member

i suspect this is a general problem with about:preferences not receiving the IPC messages that contain settings fast enough

@mrose17 mrose17 modified the milestones: 0.12.4dev, 0.12.3dev, 0.12.5dev Sep 27, 2016
@mrose17 mrose17 removed this from the 0.12.5dev milestone Oct 4, 2016
@mrose17 mrose17 added the bug label Oct 11, 2016
@mrose17 mrose17 added this to the 1.0.0 milestone Oct 17, 2016
@bsclifton
Copy link
Member

@ayumi this may be fixed now... would you be able to retest? 😄

@mrose17 mrose17 modified the milestones: 0.13.3, 1.0.0 Jan 31, 2017
@mrose17 mrose17 modified the milestones: 0.13.5, 0.13.4 Feb 14, 2017
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 12, 2017
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.1 Mar 29, 2017
@bsclifton bsclifton removed the bug label Mar 29, 2017
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.2, 1.0.0 Mar 29, 2017
@bsclifton
Copy link
Member

moving to 1.0

@ghost ghost removed this from the 1.0.0 milestone Sep 26, 2017
@ghost ghost added the QA/required label Sep 26, 2017
@ghost
Copy link

ghost commented Sep 26, 2017

QA to retest after 0.20.x

@luixxiul luixxiul added this to the 0.20.x (Developer Channel) milestone Sep 26, 2017
@cezaraugusto cezaraugusto mentioned this issue Oct 9, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Oct 9, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 9, 2017
@NejcZdovc
Fixes color flash for add funds button
542c79c 
Resolves brave#11387
Resolves brave#4066

Auditors:

Test Plan:
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Fixes color flash for add funds button
c4d0988 
Resolves brave#11387
Resolves brave#4066

Auditors:

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
8 participants
@mrose17 @ayumi @diracdeltas @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags