Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Changing default search provider no longer working #4099

Closed
jkup opened this issue Sep 18, 2016 · 0 comments · Fixed by #4104
Closed

Changing default search provider no longer working #4099

jkup opened this issue Sep 18, 2016 · 0 comments · Fixed by #4104
Assignees
@darkdh
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@jkup
Copy link
Contributor

jkup commented Sep 18, 2016

Trying to change your default search engine is not currently working in master. The error I'm seeing is:

preferences.js:619 Uncaught TypeError: Cannot read property 'children' of undefined

Which is referring to this line: https://github.com/brave/browser-laptop/blob/master/js/about/preferences.js#L619
@jkup jkup added the bug label Sep 18, 2016
@jkup jkup added this to the 0.12.2dev milestone Sep 18, 2016
@jkup jkup assigned jkup and unassigned jkup Sep 18, 2016
@darkdh darkdh self-assigned this Sep 19, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 19, 2016
@darkdh
Fix sortableTable hover effect and searchTab onClick
4ed8adb 
fix brave#4099

Auditors: @bbondy

Test Plan:

1. Go to "about:preferences#search"
2. There should be hover effect when hovering on row
3. Should be able to swtch default search engine
@darkdh darkdh mentioned this issue Sep 19, 2016
Merged
4 tasks
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

Fix sortableTable hover effect and searchTab onClick darkdh/browser-laptop
6 participants
@aekeus @jkup @alexwykoff @luixxiul @darkdh @srirambv