Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove duplicate import bookmark folder #4222

Closed
darkdh opened this issue Sep 23, 2016 · 2 comments · Fixed by #4223
Closed

Remove duplicate import bookmark folder #4222

darkdh opened this issue Sep 23, 2016 · 2 comments · Fixed by #4223
Assignees
@darkdh
Labels
feature/bookmarks feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@darkdh
Copy link
Member

darkdh commented Sep 23, 2016

import_folder_duplication

cc @alexwykoff , @bbondy
@darkdh darkdh self-assigned this Sep 23, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 23, 2016
@darkdh
Remove duplicate import bookmarks folder by
3a656bb 
1. remove dup folder in addSite
2. fix missing parentFolderId and partionNumber

fix brave#4222

Auditors: @bsclifton, @bbondy

Test Plan:
Import bookmarks twice, there should not be duplicate folders
@darkdh darkdh mentioned this issue Sep 23, 2016
Merged
4 tasks
@darkdh darkdh added this to the 0.12.2dev milestone Sep 23, 2016
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
@alexwykoff
Copy link
Contributor

Failed on OS X

@darkdh
Copy link
Member Author

darkdh commented Sep 25, 2016

The folders created by importer before this change lack parentFolderId: 0 due to 3a656bb#diff-df9d21f94d0a7809f7adb8cb43a9f6aeL130.
So them cannot be deleted due to failing to satisfy the condition 3a656bb#diff-df9d21f94d0a7809f7adb8cb43a9f6aeR115
Please remove them manually before testing it.

@alexwykoff alexwykoff mentioned this issue Oct 2, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

Remove duplicate import bookmarks folder by darkdh/browser-laptop
5 participants
@aekeus @alexwykoff @luixxiul @darkdh @srirambv